mirror/binutils-gdb
2
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2024-12-09 04:21:49 +08:00
Code Issues Packages Projects Releases Wiki Activity

* linux-thread-db.c: Update some FIXME comments.

Browse Source 
(thread_db_xfer_partial): Delete.
	(init_thread_db_ops): Do not set to_xfer_partial.
This commit is contained in:
Daniel Jacobowitz 2007-05-07 00:46:42 +00:00
parent 1da33a4a1b
commit 34091d9bf9
2 changed files with 9 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gdb/ChangeLog
View File

@ -1,3 +1,9 @@
2007-05-06 Daniel Jacobowitz <dan@codesourcery.com>
* linux-thread-db.c: Update some FIXME comments.
(thread_db_xfer_partial): Delete.
(init_thread_db_ops): Do not set to_xfer_partial.
2007-05-06 Ulrich Weigand <uweigand@de.ibm.com>
* inftarg.c, infptrace.c: Remove files.

37
gdb/linux-thread-db.c
View File

@ -52,11 +52,6 @@
/* If we're running on GNU/Linux, we must explicitly attach to any new
threads. */
/* FIXME: There is certainly some room for improvements:
- Cache LWP ids.
- Bypass libthread_db when fetching or storing registers for
threads bound to a LWP. */
/* This module's target vector. */
static struct target_ops thread_db_ops;
@ -486,9 +481,9 @@ enable_thread_event_reporting (void)
td_event_addset (&events, TD_CREATE);
#ifdef HAVE_GNU_LIBC_VERSION_H
/* FIXME: kettenis/2000-04-23: The event reporting facility is
broken for TD_DEATH events in glibc 2.1.3, so don't enable it for
now. */
/* The event reporting facility is broken for TD_DEATH events in
glibc 2.1.3, so don't enable it we have glibc but a lower
version. */
libc_version = gnu_get_libc_version ();
if (sscanf (libc_version, "%d.%d", &libc_major, &libc_minor) == 2
&& (libc_major > 2 || (libc_major == 2 && libc_minor > 1)))
@ -926,31 +921,6 @@ thread_db_wait (ptid_t ptid, struct target_waitstatus *ourstatus)
return ptid;
}
static LONGEST
thread_db_xfer_partial (struct target_ops *ops, enum target_object object,
const char *annex, gdb_byte *readbuf,
const gdb_byte *writebuf, ULONGEST offset, LONGEST len)
{
struct cleanup *old_chain = save_inferior_ptid ();
LONGEST xfer;
if (is_thread (inferior_ptid))
{
/* FIXME: This seems to be necessary to make sure breakpoints
are removed. */
if (!target_thread_alive (inferior_ptid))
inferior_ptid = pid_to_ptid (GET_PID (inferior_ptid));
else
inferior_ptid = lwp_from_thread (inferior_ptid);
}
xfer = target_beneath->to_xfer_partial (ops, object, annex,
readbuf, writebuf, offset, len);
do_cleanups (old_chain);
return xfer;
}
static void
thread_db_kill (void)
{
@ -1146,7 +1116,6 @@ init_thread_db_ops (void)
thread_db_ops.to_detach = thread_db_detach;
thread_db_ops.to_resume = thread_db_resume;
thread_db_ops.to_wait = thread_db_wait;
thread_db_ops.to_xfer_partial = thread_db_xfer_partial;
thread_db_ops.to_kill = thread_db_kill;
thread_db_ops.to_create_inferior = thread_db_create_inferior;
thread_db_ops.to_post_startup_inferior = thread_db_post_startup_inferior;