mirror/binutils-gdb
2
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2025-01-06 12:09:26 +08:00
Code Issues Packages Projects Releases Wiki Activity

memory leak in display_debug_addr

Browse Source 
* dwarf.c (display_debug_addr): Free dummy debug_addr_info entry.
	Don't return without freeing debug_addr_info on error paths.
This commit is contained in:
Alan Modra 2023-12-05 16:31:38 +10:30
parent 4cd7661483
commit 1024d59cb2
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
binutils/dwarf.c
View File

@ -7864,9 +7864,9 @@ display_debug_addr (struct dwarf_section *section,
if (header_size != 8 && header_size != 16)
{
warn (_("Corrupt %s section: expecting header size of 8 or 16, but found %zd instead\n"),
warn (_("Corrupt %s section: expecting header size of 8 or 16, but found %zd instead"),
section->name, header_size);
return 0;
break;
}
SAFE_BYTE_GET_AND_INC (length, curr_header, 4, entry);
@ -7876,8 +7876,8 @@ display_debug_addr (struct dwarf_section *section,
|| length < (size_t) (entry - curr_header))
{
warn (_("Corrupt %s section: unit_length field of %#" PRIx64
" is invalid\n"), section->name, length);
return 0;
" is invalid"), section->name, length);
break;
}
end = curr_header + length;
SAFE_BYTE_GET_AND_INC (version, curr_header, 2, entry);
@ -7899,7 +7899,7 @@ display_debug_addr (struct dwarf_section *section,
{
warn (_("Corrupt %s section: address size (%x) is wrong"),
section->name, address_size);
return 0;
break;
}
while ((size_t) (end - entry) >= address_size)
@ -7914,8 +7914,9 @@ display_debug_addr (struct dwarf_section *section,
}
printf ("\n");
free (debug_addr_info[count]);
free (debug_addr_info);
return 1;
return i == count;
}
/* Display the .debug_str_offsets and .debug_str_offsets.dwo sections. */