From 0b47d9858ca0805cd52ba959276d08899c7b9f8c Mon Sep 17 00:00:00 2001
From: Simon Marchi <simon.marchi@ericsson.com>
Date: Wed, 30 May 2018 14:54:36 -0400
Subject: [PATCH] Remove regcache_raw_update

Remove regcache_raw_update, update callers to use
readable_regcache::raw_update instead.

gdb/ChangeLog:

	* regcache.h (regcache_raw_update): Remove, update callers to
	use readable_regcache::raw_update instead.
	* regcache.c (regcache_raw_update): Remove.
---
 gdb/ChangeLog  | 6 ++++++
 gdb/regcache.c | 8 --------
 gdb/regcache.h | 5 +----
 gdb/remote.c   | 2 +-
 4 files changed, 8 insertions(+), 13 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index ef6d92118ed..4f451a2910e 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,9 @@
+2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
+
+	* regcache.h (regcache_raw_update): Remove, update callers to
+	use readable_regcache::raw_update instead.
+	* regcache.c (regcache_raw_update): Remove.
+
 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
 
 	* regcache.h (regcache_register_status): Remove, update callers
diff --git a/gdb/regcache.c b/gdb/regcache.c
index dd1dde234c9..64d167a3894 100644
--- a/gdb/regcache.c
+++ b/gdb/regcache.c
@@ -488,14 +488,6 @@ registers_changed (void)
   alloca (0);
 }
 
-void
-regcache_raw_update (struct regcache *regcache, int regnum)
-{
-  gdb_assert (regcache != NULL);
-
-  regcache->raw_update (regnum);
-}
-
 void
 regcache::raw_update (int regnum)
 {
diff --git a/gdb/regcache.h b/gdb/regcache.h
index fa177b58aa3..dffc27f17c1 100644
--- a/gdb/regcache.h
+++ b/gdb/regcache.h
@@ -35,10 +35,6 @@ extern struct regcache *get_thread_arch_aspace_regcache (ptid_t,
 							 struct gdbarch *,
 							 struct address_space *);
 
-/* Make certain that the register REGNUM in REGCACHE is up-to-date.  */
-
-void regcache_raw_update (struct regcache *regcache, int regnum);
-
 /* Transfer a raw register [0..NUM_REGS) between core-gdb and the
    regcache.  The read variants return the status of the register.  */
 
@@ -257,6 +253,7 @@ class readable_regcache : public reg_buffer
   enum register_status raw_read_part (int regnum, int offset, int len,
 				      gdb_byte *buf);
 
+  /* Make certain that the register REGNUM is up-to-date.  */
   virtual void raw_update (int regnum) = 0;
 
   enum register_status cooked_read (int regnum, gdb_byte *buf);
diff --git a/gdb/remote.c b/gdb/remote.c
index 3df9ad4fbe3..3aca5fb2901 100644
--- a/gdb/remote.c
+++ b/gdb/remote.c
@@ -8339,7 +8339,7 @@ remote_target::prepare_to_store (struct regcache *regcache)
       /* Make sure all the necessary registers are cached.  */
       for (i = 0; i < gdbarch_num_regs (regcache->arch ()); i++)
 	if (rsa->regs[i].in_g_packet)
-	  regcache_raw_update (regcache, rsa->regs[i].regnum);
+	  regcache->raw_update (rsa->regs[i].regnum);
       break;
     case PACKET_ENABLE:
       break;