mirror/binutils-gdb
2
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2025-04-24 14:53:34 +08:00
Code Issues Packages Projects Releases Wiki Activity

install_variable cannot fail

Browse Source 
I noticed that install_variable will never return false, so this patch
changes the return type to void.  I couldn't find a spot in history
where it did return false, maybe it's always been like this.

gdb/ChangeLog
2020-12-11  Tom Tromey  <tom@tromey.com>

	* varobj.c (varobj_create): Update.
	(install_variable): Return void.
This commit is contained in:
Tom Tromey 2020-12-11 09:33:36 -07:00
parent 1345dee280
commit 07d9937a20
2 changed files with 8 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/ChangeLog
View File

@ -1,3 +1,8 @@
2020-12-11 Tom Tromey <tom@tromey.com>
* varobj.c (varobj_create): Update.
(install_variable): Return void.
2020-12-11 Tom Tromey <tom@tromey.com>
* varobj.c (instantiate_pretty_printer): Use gdbpy_ref.

12
gdb/varobj.c
View File

@ -142,7 +142,7 @@ static int delete_variable (struct varobj *, bool);
static void delete_variable_1 (int *, struct varobj *, bool, bool);
static bool install_variable (struct varobj *);
static void install_variable (struct varobj *);
static void uninstall_variable (struct varobj *);
@ -390,11 +390,7 @@ varobj_create (const char *objname,
if ((var != NULL) && (objname != NULL))
{
var->obj_name = objname;
/* If a varobj name is duplicated, the install will fail so
we must cleanup. */
if (!install_variable (var.get ()))
return NULL;
install_variable (var.get ());
}
return var.release ();
@ -1733,7 +1729,7 @@ delete_variable_1 (int *delcountp, struct varobj *var, bool only_children_p,
}
/* Install the given variable VAR with the object name VAR->OBJ_NAME. */
static bool
static void
install_variable (struct varobj *var)
{
hashval_t hash = htab_hash_string (var->obj_name.c_str ());
@ -1749,8 +1745,6 @@ install_variable (struct varobj *var)
/* If root, add varobj to root list. */
if (is_root_p (var))
rootlist.push_front (var->root);
return true; /* OK */
}
/* Uninstall the object VAR. */