mirror/binutils-gdb
2
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2025-04-24 14:53:34 +08:00
Code Issues Packages Projects Releases Wiki Activity

bfd+ld: when / whether to generate .c files

Browse Source 
Having been irritated by seeing bfd/elf{32,64}-aarch64.c to be re-
generated in x86-only builds, I came across 769a27ade588 ("Re: bfd
BLD-POTFILES.in dependencies"). I think this went slightly too far, as
outside of maintainer mode dependencies will cause the subset of files
to be (re-)generated which are actually needed for the build.
Generating them all is only needed when wanting to update certain files
under bfd/po/, i.e. in maintainer mode.

In the course of looking around in an attempt to try to understand how
things are meant to work, I further noticed that ld has got things
slightly wrong too: BLD-POTFILES.in depending on $(BLD_POTFILES) isn't
quite right (the output doesn't change when any of the enumerated files
changes; it's the mere presence which matters); like in bfd it looks
like we would better extend BUILT_SOURCES accordingly.

Furthermore it became apparent that ld fails to enumerate the .c files
generated from the .l and .y ones. While in their absence it was benign
whether translatable strings in the source files were actually marked as
such, this now becomes relevant. Mark respective strings at the same
time, but skipping ones which look to be of interest for debugging
purposes only (e.g. such used by printf() enclosed in #ifdef TRACE).
This commit is contained in:
Jan Beulich 2023-04-04 08:50:18 +02:00
parent 19cacf6729
commit 02d44d7658
7 changed files with 13 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
bfd/Makefile.am
View File

@ -721,7 +721,7 @@ BUILD_HFILES = \
bfdver.h elf32-target.h elf64-target.h targmatch.h
# Ensure they are built early:
BUILT_SOURCES = $(BUILD_HFILES) $(BUILD_CFILES)
BUILT_SOURCES = $(BUILD_HFILES) @MAINT@ $(BUILD_CFILES)
HFILES = $(SOURCE_HFILES) $(BUILD_HFILES)

2
bfd/Makefile.in
View File

@ -1174,7 +1174,7 @@ BUILD_HFILES = \
# Ensure they are built early:
BUILT_SOURCES = $(BUILD_HFILES) $(BUILD_CFILES)
BUILT_SOURCES = $(BUILD_HFILES) @MAINT@ $(BUILD_CFILES)
HFILES = $(SOURCE_HFILES) $(BUILD_HFILES)
BFD_H_DEPS = $(INCDIR)/ansidecl.h $(INCDIR)/symcat.h $(INCDIR)/diagnostics.h
LOCAL_H_DEPS = libbfd.h sysdep.h config.h

5
ld/Makefile.am
View File

@ -493,7 +493,8 @@ GENERATED_HFILES = ldgram.h ldemul-list.h deffilep.h
# Require an early dependency on the generated headers, as the dependency
# tracking will not cause them to be built beforehand.
BUILT_SOURCES = $(GENERATED_HFILES)
BUILT_SOURCES = $(GENERATED_HFILES) @MAINT@ $(GENERATED_CFILES) \
$(ALL_EMULATION_SOURCES) $(ALL_64_EMULATION_SOURCES)
OFILES = ldgram.@OBJEXT@ ldlex-wrapper.@OBJEXT@ lexsup.@OBJEXT@ ldlang.@OBJEXT@ \
mri.@OBJEXT@ ldctor.@OBJEXT@ ldmain.@OBJEXT@ plugin.@OBJEXT@ \
@ -548,7 +549,7 @@ po/SRC-POTFILES.in: @MAINT@ Makefile
for f in $(SRC_POTFILES); do echo $$f; done | LC_ALL=C sort > $@-tmp \
&& mv $@-tmp $(srcdir)/po/SRC-POTFILES.in
po/BLD-POTFILES.in: @MAINT@ Makefile $(BLD_POTFILES)
po/BLD-POTFILES.in: @MAINT@ Makefile
for f in $(BLD_POTFILES); do echo $$f; done | LC_ALL=C sort > $@-tmp \
&& mv $@-tmp $(srcdir)/po/BLD-POTFILES.in

5
ld/Makefile.in
View File

@ -992,7 +992,8 @@ GENERATED_HFILES = ldgram.h ldemul-list.h deffilep.h
# Require an early dependency on the generated headers, as the dependency
# tracking will not cause them to be built beforehand.
BUILT_SOURCES = $(GENERATED_HFILES)
BUILT_SOURCES = $(GENERATED_HFILES) @MAINT@ $(GENERATED_CFILES) \
$(ALL_EMULATION_SOURCES) $(ALL_64_EMULATION_SOURCES)
OFILES = ldgram.@OBJEXT@ ldlex-wrapper.@OBJEXT@ lexsup.@OBJEXT@ ldlang.@OBJEXT@ \
mri.@OBJEXT@ ldctor.@OBJEXT@ ldmain.@OBJEXT@ plugin.@OBJEXT@ \
ldwrite.@OBJEXT@ ldexp.@OBJEXT@ ldemul.@OBJEXT@ ldver.@OBJEXT@ ldmisc.@OBJEXT@ \
@ -2288,7 +2289,7 @@ po/SRC-POTFILES.in: @MAINT@ Makefile
for f in $(SRC_POTFILES); do echo $$f; done | LC_ALL=C sort > $@-tmp \
&& mv $@-tmp $(srcdir)/po/SRC-POTFILES.in
po/BLD-POTFILES.in: @MAINT@ Makefile $(BLD_POTFILES)
po/BLD-POTFILES.in: @MAINT@ Makefile
for f in $(BLD_POTFILES); do echo $$f; done | LC_ALL=C sort > $@-tmp \
&& mv $@-tmp $(srcdir)/po/BLD-POTFILES.in

2
ld/deffilep.y
View File

@ -1134,7 +1134,7 @@ def_image_name (const char *name, bfd_vma base, int is_dll)
const char* image_name = lbasename (name);
if (image_name != name)
einfo ("%s:%d: Warning: path components stripped from %s, '%s'\n",
einfo (_("%s:%d: Warning: path components stripped from %s, '%s'\n"),
def_filename, linenumber, is_dll ? "LIBRARY" : "NAME",
name);
free (def->name);

4
ld/ldgram.y
View File

@ -720,7 +720,7 @@ length:
fill_exp:
mustbe_exp
{
$$ = exp_get_fill ($1, 0, "fill value");
$$ = exp_get_fill ($1, 0, _("fill value"));
}
;
@ -1512,7 +1512,7 @@ yyerror(arg)
einfo (_("%P:%s: file format not recognized; treating as linker script\n"),
ldlex_filename ());
if (error_index > 0 && error_index < ERROR_NAME_MAX)
einfo ("%F%P:%pS: %s in %s\n", NULL, arg, error_names[error_index - 1]);
einfo (_("%F%P:%pS: %s in %s\n"), NULL, arg, error_names[error_index - 1]);
else
einfo ("%F%P:%pS: %s\n", NULL, arg);
}

4
ld/ldlex.l
View File

@ -489,8 +489,8 @@ V_IDENTIFIER [*?.$_a-zA-Z\[\]\-\!\^\\]([*?.$_a-zA-Z0-9\[\]\-\!\^\\]|::)*
return END;
}
<SCRIPT,WILD,MRI,VERS_START,VERS_SCRIPT,VERS_NODE>. lex_warn_invalid (" in script", yytext);
<EXPRESSION>. lex_warn_invalid (" in expression", yytext);
<SCRIPT,WILD,MRI,VERS_START,VERS_SCRIPT,VERS_NODE>. lex_warn_invalid (_(" in script"), yytext);
<EXPRESSION>. lex_warn_invalid (_(" in expression"), yytext);
%%