Fix gold to group sections correctly via linker script.
In PR 15370, it is noted that gold does not distinguish between
"*(.foo .bar)" and "*(.foo) *(.bar)" in linker scripts. In both
cases, gold groups all .foo sections together, followed by all
.bar sections, whereas in the first case, it should collect all
.foo and .bar sections in the order seen.
If you add sort specs, the Gnu linker has some bizarre corner
cases that I do not try to replicate. In particular,
"*(SORT_BY_NAME(.foo) SORT_BY_NAME(.bar))" does the same thing
as "*(.foo) *(.bar)". But if you apply a sort spec
to just one of several patterns, say, "*(SORT_BY_NAME(.foo) .bar)",
the Gnu linker will collect any .bar section it sees before the
first .foo, then all .foo sections, then all remaining .bar
sections. With this patch, if any of the input patterns have a
sort spec, gold will group them all as it did before; e.g.,
all .foo sections followed by all .bar sections.
2015-06-03 Cary Coutant <ccoutant@gmail.com>
gold/
PR gold/15370
* script-sections.cc
(Output_section_element_input::set_section_addresses): When there
are several patterns with no sort spec, put all sections in the same
bin.
* testsuite/Makefile.am (script_test_12): New testcase.
(script_test_12i): New testcase.
* testsuite/Makefile.in: Regenerate.
* testsuite/script_test_12.t: New test linker script.
* testsuite/script_test_12i.t: New test linker script.
* testsuite/script_test_12a.c: New test source file.
* testsuite/script_test_12b.c: New test source file.
2015-06-04 10:11:42 +08:00
|
|
|
/* script_test_12a.c -- a test case for gold
|
|
|
|
|
2019-01-01 18:31:27 +08:00
|
|
|
Copyright (C) 2015-2019 Free Software Foundation, Inc.
|
Fix gold to group sections correctly via linker script.
In PR 15370, it is noted that gold does not distinguish between
"*(.foo .bar)" and "*(.foo) *(.bar)" in linker scripts. In both
cases, gold groups all .foo sections together, followed by all
.bar sections, whereas in the first case, it should collect all
.foo and .bar sections in the order seen.
If you add sort specs, the Gnu linker has some bizarre corner
cases that I do not try to replicate. In particular,
"*(SORT_BY_NAME(.foo) SORT_BY_NAME(.bar))" does the same thing
as "*(.foo) *(.bar)". But if you apply a sort spec
to just one of several patterns, say, "*(SORT_BY_NAME(.foo) .bar)",
the Gnu linker will collect any .bar section it sees before the
first .foo, then all .foo sections, then all remaining .bar
sections. With this patch, if any of the input patterns have a
sort spec, gold will group them all as it did before; e.g.,
all .foo sections followed by all .bar sections.
2015-06-03 Cary Coutant <ccoutant@gmail.com>
gold/
PR gold/15370
* script-sections.cc
(Output_section_element_input::set_section_addresses): When there
are several patterns with no sort spec, put all sections in the same
bin.
* testsuite/Makefile.am (script_test_12): New testcase.
(script_test_12i): New testcase.
* testsuite/Makefile.in: Regenerate.
* testsuite/script_test_12.t: New test linker script.
* testsuite/script_test_12i.t: New test linker script.
* testsuite/script_test_12a.c: New test source file.
* testsuite/script_test_12b.c: New test source file.
2015-06-04 10:11:42 +08:00
|
|
|
Written by Cary Coutant <ccoutant@gmail.com>.
|
|
|
|
|
|
|
|
This file is part of gold.
|
|
|
|
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
|
|
it under the terms of the GNU General Public License as published by
|
|
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
|
|
(at your option) any later version.
|
|
|
|
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
GNU General Public License for more details.
|
|
|
|
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
|
|
along with this program; if not, write to the Free Software
|
|
|
|
Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston,
|
|
|
|
MA 02110-1301, USA.
|
|
|
|
|
|
|
|
This tests linker script behavior, that gold distinguishes correctly
|
|
|
|
between
|
|
|
|
*(.x1) *(.x2) *(.x3)
|
|
|
|
and
|
|
|
|
*(.x1 .x2 .x3)
|
|
|
|
in an input section spec. In the first case, the output section
|
|
|
|
should contain all .x1 sections, followed by all .x2 sections,
|
|
|
|
then all .x3 sections; i.e.:
|
|
|
|
script_test_12a.o(.x1)
|
|
|
|
script_test_12b.o(.x1)
|
|
|
|
script_test_12a.o(.x2)
|
|
|
|
script_test_12b.o(.x2)
|
|
|
|
script_test_12a.o(.x3)
|
|
|
|
script_test_12b.o(.x3)
|
|
|
|
|
|
|
|
In the second case, the output section should interleave the
|
|
|
|
.x1, .x2, and .x3 sections in the order seen; i.e.:
|
|
|
|
script_test_12a.o(.x1)
|
|
|
|
script_test_12a.o(.x2)
|
|
|
|
script_test_12a.o(.x3)
|
|
|
|
script_test_12b.o(.x1)
|
|
|
|
script_test_12b.o(.x2)
|
|
|
|
script_test_12b.o(.x3)
|
|
|
|
|
|
|
|
The linker scripts set the absolute symbol INTERLEAVED, which we
|
|
|
|
test here to determine which ordering to expect. The scripts also
|
|
|
|
define the symbols test_array_start and test_array_end.
|
|
|
|
*/
|
|
|
|
|
|
|
|
extern int test_array_start;
|
|
|
|
extern int test_array_end;
|
2015-10-05 22:57:16 +08:00
|
|
|
extern char interleaved __attribute__((__aligned__(1)));
|
Fix gold to group sections correctly via linker script.
In PR 15370, it is noted that gold does not distinguish between
"*(.foo .bar)" and "*(.foo) *(.bar)" in linker scripts. In both
cases, gold groups all .foo sections together, followed by all
.bar sections, whereas in the first case, it should collect all
.foo and .bar sections in the order seen.
If you add sort specs, the Gnu linker has some bizarre corner
cases that I do not try to replicate. In particular,
"*(SORT_BY_NAME(.foo) SORT_BY_NAME(.bar))" does the same thing
as "*(.foo) *(.bar)". But if you apply a sort spec
to just one of several patterns, say, "*(SORT_BY_NAME(.foo) .bar)",
the Gnu linker will collect any .bar section it sees before the
first .foo, then all .foo sections, then all remaining .bar
sections. With this patch, if any of the input patterns have a
sort spec, gold will group them all as it did before; e.g.,
all .foo sections followed by all .bar sections.
2015-06-03 Cary Coutant <ccoutant@gmail.com>
gold/
PR gold/15370
* script-sections.cc
(Output_section_element_input::set_section_addresses): When there
are several patterns with no sort spec, put all sections in the same
bin.
* testsuite/Makefile.am (script_test_12): New testcase.
(script_test_12i): New testcase.
* testsuite/Makefile.in: Regenerate.
* testsuite/script_test_12.t: New test linker script.
* testsuite/script_test_12i.t: New test linker script.
* testsuite/script_test_12a.c: New test source file.
* testsuite/script_test_12b.c: New test source file.
2015-06-04 10:11:42 +08:00
|
|
|
|
|
|
|
int
|
|
|
|
main(void)
|
|
|
|
{
|
|
|
|
int last = 0;
|
|
|
|
int *p;
|
|
|
|
long should_be_interleaved = (long)&interleaved;
|
|
|
|
int mask = (should_be_interleaved == 1 ? 0x7f : 0xff);
|
|
|
|
for (p = &test_array_start; p < &test_array_end; ++p)
|
|
|
|
{
|
|
|
|
int next = *p & mask;
|
|
|
|
if (next <= last)
|
|
|
|
return 1;
|
|
|
|
last = next;
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
int a1[] __attribute((section(".x1"))) = { 0x01, 0x02, 0x03, 0x04 };
|
|
|
|
int a2[] __attribute((section(".x2"))) = { 0x11, 0x12, 0x13, 0x14};
|
|
|
|
int a3[] __attribute((section(".x3"))) = { 0x21, 0x22, 0x23, 0x24 };
|
2016-06-24 00:45:25 +08:00
|
|
|
int a4[] __attribute((section(".x4"))) = { 0xff, 0xff, 0xff, 0xff };
|