RISC-V: Optimize relaxation of gp with max_alignment.
This should be the first related issue, which posted in riscv-gnu-toolchain,
https://github.com/riscv-collab/riscv-gnu-toolchain/issues/497
If the output sections are not between gp and the symbol, then their alignments
shouldn't affect the gp relaxation. However, this patch improves this idea
even more, it limits the range to the gp+-2k, which means only the output
section which are in the [gp-2K, gp+2K) range need to be considered.
Even if the output section candidates may be different for each relax passes,
the symbol that can be relaxed ar this round will not be truncated at next
round. That is because this round you can do relaxation which means that the
section where the symbol is located is within the [gp-2K, gp+2K) range, so all
the output section alignments between them should be considered. In other
words, if the alignments between them may cause truncated, then we should
already preserve the size and won't do the gp relaxation this time.
This patch can resolve the github issue which mentioned above, and also passed
all gcc/binutils regressions of riscv-gnu-toolchain, so should be worth and
safe enough to commit.
Originally, this patch also do the same optimization for the call relaxations,
https://sourceware.org/pipermail/binutils/2022-October/123918.html
But just in case there is something that has not been considered, we only
deal with the gp relaxation at this time.
bfd/
* elfnn-riscv.c (riscv_elf_link_hash_table): Added new bfd_vma,
max_alignment_for_gp. It is used to record the maximum alignment of
the output sections, which are in the [gp-2K, gp+2k) range.
(riscv_elf_link_hash_table_create): Init max_alignment_for_gp to -1.
(_bfd_riscv_get_max_alignment): Added new parameter, gp. If gp is
zero, then all the output section alignments are possible candidates;
Otherwise, only the output sections which are in the [gp-2K, gp+2K)
range need to be considered.
(_bfd_riscv_relax_lui): Called _bfd_riscv_get_max_alignment with the
non-zero gp if the max_alignment_for_gp is -1.
(_bfd_riscv_relax_pc): Likewise.
(_bfd_riscv_relax_section): Record the first input section, so that
we can reset the max_alignment_for_gp for each repeated relax passes.
ld/
* testsuite/ld-riscv-elf/ld-riscv-elf.exp: Updated.
* testsuite/ld-riscv-elf/relax-max-align-gp.*: New testcase. It fails
without this patch.
2022-10-27 11:19:15 +08:00
|
|
|
#source: relax-max-align-gp.s
|
|
|
|
|
#ld:
|
|
|
|
|
#objdump: -d
|
|
|
|
|
|
|
|
|
|
.*:[ ]+file format .*
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Disassembly of section .text:
|
|
|
|
|
|
|
|
|
|
0+[0-9a-f]+ <_start>:
|
2023-09-01 18:26:46 +08:00
|
|
|
.*:[ ]+[0-9a-f]+[ ]+addi[ ]+.*<gdata>
|
RISC-V: Optimize relaxation of gp with max_alignment.
This should be the first related issue, which posted in riscv-gnu-toolchain,
https://github.com/riscv-collab/riscv-gnu-toolchain/issues/497
If the output sections are not between gp and the symbol, then their alignments
shouldn't affect the gp relaxation. However, this patch improves this idea
even more, it limits the range to the gp+-2k, which means only the output
section which are in the [gp-2K, gp+2K) range need to be considered.
Even if the output section candidates may be different for each relax passes,
the symbol that can be relaxed ar this round will not be truncated at next
round. That is because this round you can do relaxation which means that the
section where the symbol is located is within the [gp-2K, gp+2K) range, so all
the output section alignments between them should be considered. In other
words, if the alignments between them may cause truncated, then we should
already preserve the size and won't do the gp relaxation this time.
This patch can resolve the github issue which mentioned above, and also passed
all gcc/binutils regressions of riscv-gnu-toolchain, so should be worth and
safe enough to commit.
Originally, this patch also do the same optimization for the call relaxations,
https://sourceware.org/pipermail/binutils/2022-October/123918.html
But just in case there is something that has not been considered, we only
deal with the gp relaxation at this time.
bfd/
* elfnn-riscv.c (riscv_elf_link_hash_table): Added new bfd_vma,
max_alignment_for_gp. It is used to record the maximum alignment of
the output sections, which are in the [gp-2K, gp+2k) range.
(riscv_elf_link_hash_table_create): Init max_alignment_for_gp to -1.
(_bfd_riscv_get_max_alignment): Added new parameter, gp. If gp is
zero, then all the output section alignments are possible candidates;
Otherwise, only the output sections which are in the [gp-2K, gp+2K)
range need to be considered.
(_bfd_riscv_relax_lui): Called _bfd_riscv_get_max_alignment with the
non-zero gp if the max_alignment_for_gp is -1.
(_bfd_riscv_relax_pc): Likewise.
(_bfd_riscv_relax_section): Record the first input section, so that
we can reset the max_alignment_for_gp for each repeated relax passes.
ld/
* testsuite/ld-riscv-elf/ld-riscv-elf.exp: Updated.
* testsuite/ld-riscv-elf/relax-max-align-gp.*: New testcase. It fails
without this patch.
2022-10-27 11:19:15 +08:00
|
|
|
.*:[ ]+[0-9a-f]+[ ]+jal[ ]+.*
|
|
|
|
|
.*:[ ]+[0-9a-f]+[ ]+j[ ]+.*
|
|
|
|
|
.*:[ ]+[0-9a-f]+[ ]+nop
|
|
|
|
|
.*:[ ]+[0-9a-f]+[ ]+nop
|
|
|
|
|
.*:[ ]+[0-9a-f]+[ ]+nop
|
|
|
|
|
.*:[ ]+[0-9a-f]+[ ]+nop
|
|
|
|
|
.*:[ ]+[0-9a-f]+[ ]+nop
|
|
|
|
|
.*:[ ]+[0-9a-f]+[ ]+nop
|
|
|
|
|
.*:[ ]+[0-9a-f]+[ ]+nop
|
|
|
|
|
.*:[ ]+[0-9a-f]+[ ]+nop
|
|
|
|
|
.*:[ ]+[0-9a-f]+[ ]+nop
|
|
|
|
|
.*:[ ]+[0-9a-f]+[ ]+nop
|
|
|
|
|
.*:[ ]+[0-9a-f]+[ ]+nop
|
|
|
|
|
.*:[ ]+[0-9a-f]+[ ]+nop
|
|
|
|
|
.*:[ ]+[0-9a-f]+[ ]+nop
|
|
|
|
|
.*:[ ]+[0-9a-f]+[ ]+nop
|
|
|
|
|
.*:[ ]+[0-9a-f]+[ ]+nop
|
|
|
|
|
.*:[ ]+[0-9a-f]+[ ]+nop
|
|
|
|
|
.*:[ ]+[0-9a-f]+[ ]+nop
|
|
|
|
|
.*:[ ]+[0-9a-f]+[ ]+nop
|
|
|
|
|
.*:[ ]+[0-9a-f]+[ ]+nop
|
|
|
|
|
.*:[ ]+[0-9a-f]+[ ]+nop
|
|
|
|
|
.*:[ ]+[0-9a-f]+[ ]+nop
|
|
|
|
|
.*:[ ]+[0-9a-f]+[ ]+nop
|
|
|
|
|
.*:[ ]+[0-9a-f]+[ ]+nop
|
|
|
|
|
.*:[ ]+[0-9a-f]+[ ]+nop
|
|
|
|
|
.*:[ ]+[0-9a-f]+[ ]+nop
|
|
|
|
|
.*:[ ]+[0-9a-f]+[ ]+nop
|
|
|
|
|
.*:[ ]+[0-9a-f]+[ ]+nop
|
|
|
|
|
.*:[ ]+[0-9a-f]+[ ]+nop
|
|
|
|
|
.*:[ ]+[0-9a-f]+[ ]+nop
|
|
|
|
|
|
|
|
|
|
0+[0-9a-f]+ <func>:
|
|
|
|
|
.*:[ ]+[0-9a-f]+[ ]+ret
|
|
|
|
|
[ ]+...
|
