2018-01-26 20:07:29 +08:00
|
|
|
/* Self tests for scoped_fd for GDB, the GNU debugger.
|
|
|
|
|
2019-01-01 14:01:51 +08:00
|
|
|
Copyright (C) 2018-2019 Free Software Foundation, Inc.
|
2018-01-26 20:07:29 +08:00
|
|
|
|
|
|
|
This file is part of GDB.
|
|
|
|
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
|
|
it under the terms of the GNU General Public License as published by
|
|
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
|
|
(at your option) any later version.
|
|
|
|
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
GNU General Public License for more details.
|
|
|
|
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
|
|
|
|
#include "defs.h"
|
|
|
|
|
Use mkostemp, not mkstemp
I noticed that gdb could leak file descriptors coming from mkstemp.
This patch fixes the problem by importing the gnulib mkostemp instead,
and then changing gdb to pass O_CLOEXEC.
A small gnulib patch was needed. This has already been accepted
upstream.
gdb/ChangeLog
2018-10-27 Tom Tromey <tom@tromey.com>
* unittests/scoped_mmap-selftests.c (test_normal): Use
gdb_mkostemp_cloexec.
* unittests/scoped_fd-selftests.c (test_destroy, test_release):
Use gdb_mkostemp_cloexec.
* gnulib/aclocal-m4-deps.mk, gnulib/aclocal.m4,
gnulib/config.in, gnulib/configure,
gnulib/import/Makefile.am, gnulib/import/Makefile.in,
gnulib/import/m4/gnulib-cache.m4,
gnulib/import/m4/gnulib-comp.m4: Update.
* gnulib/import/m4/mkostemp.m4: New file.
* gnulib/import/m4/mkstemp.m4: Remove.
* gnulib/import/mkostemp.c: New file.
* gnulib/import/mkstemp.m4: Remove.
* gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Remove
mkstemp, add mkostemp. Apply new patch.
* gnulib/import/stdlib.in.h: Apply patch.
* gnulib/patches/0002-mkostemp-mkostemps-Fix-compilation-error-in-C-mode-o.patch:
New file.
* dwarf-index-write.c (write_psymtabs_to_index): Use
gdb_mkostemp_cloexec.
* common/filestuff.h (gdb_mkostemp_cloexec): New function.
2018-09-21 06:04:04 +08:00
|
|
|
#include "common/filestuff.h"
|
2018-01-26 20:07:29 +08:00
|
|
|
#include "common/scoped_fd.h"
|
|
|
|
#include "config.h"
|
2019-01-24 01:21:39 +08:00
|
|
|
#include "common/selftest.h"
|
2018-01-26 20:07:29 +08:00
|
|
|
|
|
|
|
namespace selftests {
|
|
|
|
namespace scoped_fd {
|
|
|
|
|
|
|
|
/* Test that the file descriptor is closed. */
|
|
|
|
static void
|
|
|
|
test_destroy ()
|
|
|
|
{
|
|
|
|
char filename[] = "scoped_fd-selftest-XXXXXX";
|
Use mkostemp, not mkstemp
I noticed that gdb could leak file descriptors coming from mkstemp.
This patch fixes the problem by importing the gnulib mkostemp instead,
and then changing gdb to pass O_CLOEXEC.
A small gnulib patch was needed. This has already been accepted
upstream.
gdb/ChangeLog
2018-10-27 Tom Tromey <tom@tromey.com>
* unittests/scoped_mmap-selftests.c (test_normal): Use
gdb_mkostemp_cloexec.
* unittests/scoped_fd-selftests.c (test_destroy, test_release):
Use gdb_mkostemp_cloexec.
* gnulib/aclocal-m4-deps.mk, gnulib/aclocal.m4,
gnulib/config.in, gnulib/configure,
gnulib/import/Makefile.am, gnulib/import/Makefile.in,
gnulib/import/m4/gnulib-cache.m4,
gnulib/import/m4/gnulib-comp.m4: Update.
* gnulib/import/m4/mkostemp.m4: New file.
* gnulib/import/m4/mkstemp.m4: Remove.
* gnulib/import/mkostemp.c: New file.
* gnulib/import/mkstemp.m4: Remove.
* gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Remove
mkstemp, add mkostemp. Apply new patch.
* gnulib/import/stdlib.in.h: Apply patch.
* gnulib/patches/0002-mkostemp-mkostemps-Fix-compilation-error-in-C-mode-o.patch:
New file.
* dwarf-index-write.c (write_psymtabs_to_index): Use
gdb_mkostemp_cloexec.
* common/filestuff.h (gdb_mkostemp_cloexec): New function.
2018-09-21 06:04:04 +08:00
|
|
|
int fd = gdb_mkostemp_cloexec (filename);
|
2018-01-26 20:07:29 +08:00
|
|
|
SELF_CHECK (fd >= 0);
|
|
|
|
|
|
|
|
unlink (filename);
|
|
|
|
errno = 0;
|
|
|
|
{
|
|
|
|
::scoped_fd sfd (fd);
|
|
|
|
|
|
|
|
SELF_CHECK (sfd.get () == fd);
|
|
|
|
}
|
|
|
|
|
|
|
|
SELF_CHECK (close (fd) == -1 && errno == EBADF);
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Test that the file descriptor can be released. */
|
|
|
|
static void
|
|
|
|
test_release ()
|
|
|
|
{
|
|
|
|
char filename[] = "scoped_fd-selftest-XXXXXX";
|
Use mkostemp, not mkstemp
I noticed that gdb could leak file descriptors coming from mkstemp.
This patch fixes the problem by importing the gnulib mkostemp instead,
and then changing gdb to pass O_CLOEXEC.
A small gnulib patch was needed. This has already been accepted
upstream.
gdb/ChangeLog
2018-10-27 Tom Tromey <tom@tromey.com>
* unittests/scoped_mmap-selftests.c (test_normal): Use
gdb_mkostemp_cloexec.
* unittests/scoped_fd-selftests.c (test_destroy, test_release):
Use gdb_mkostemp_cloexec.
* gnulib/aclocal-m4-deps.mk, gnulib/aclocal.m4,
gnulib/config.in, gnulib/configure,
gnulib/import/Makefile.am, gnulib/import/Makefile.in,
gnulib/import/m4/gnulib-cache.m4,
gnulib/import/m4/gnulib-comp.m4: Update.
* gnulib/import/m4/mkostemp.m4: New file.
* gnulib/import/m4/mkstemp.m4: Remove.
* gnulib/import/mkostemp.c: New file.
* gnulib/import/mkstemp.m4: Remove.
* gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Remove
mkstemp, add mkostemp. Apply new patch.
* gnulib/import/stdlib.in.h: Apply patch.
* gnulib/patches/0002-mkostemp-mkostemps-Fix-compilation-error-in-C-mode-o.patch:
New file.
* dwarf-index-write.c (write_psymtabs_to_index): Use
gdb_mkostemp_cloexec.
* common/filestuff.h (gdb_mkostemp_cloexec): New function.
2018-09-21 06:04:04 +08:00
|
|
|
int fd = gdb_mkostemp_cloexec (filename);
|
2018-01-26 20:07:29 +08:00
|
|
|
SELF_CHECK (fd >= 0);
|
|
|
|
|
|
|
|
unlink (filename);
|
|
|
|
errno = 0;
|
|
|
|
{
|
|
|
|
::scoped_fd sfd (fd);
|
|
|
|
|
|
|
|
SELF_CHECK (sfd.release () == fd);
|
|
|
|
}
|
|
|
|
|
|
|
|
SELF_CHECK (close (fd) == 0 || errno != EBADF);
|
|
|
|
}
|
|
|
|
|
2018-09-21 06:30:47 +08:00
|
|
|
/* Test that the file descriptor can be converted to a FILE *. */
|
|
|
|
static void
|
|
|
|
test_to_file ()
|
|
|
|
{
|
|
|
|
char filename[] = "scoped_fd-selftest-XXXXXX";
|
|
|
|
|
|
|
|
::scoped_fd sfd (gdb_mkostemp_cloexec (filename));
|
|
|
|
SELF_CHECK (sfd.get () >= 0);
|
|
|
|
|
|
|
|
unlink (filename);
|
|
|
|
|
|
|
|
gdb_file_up file = sfd.to_file ("rw");
|
|
|
|
SELF_CHECK (file != nullptr);
|
|
|
|
SELF_CHECK (sfd.get () == -1);
|
|
|
|
}
|
|
|
|
|
2018-01-26 20:07:29 +08:00
|
|
|
/* Run selftests. */
|
|
|
|
static void
|
|
|
|
run_tests ()
|
|
|
|
{
|
|
|
|
test_destroy ();
|
|
|
|
test_release ();
|
2018-09-21 06:30:47 +08:00
|
|
|
test_to_file ();
|
2018-01-26 20:07:29 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
} /* namespace scoped_fd */
|
|
|
|
} /* namespace selftests */
|
|
|
|
|
|
|
|
void
|
|
|
|
_initialize_scoped_fd_selftests ()
|
|
|
|
{
|
|
|
|
selftests::register_test ("scoped_fd",
|
|
|
|
selftests::scoped_fd::run_tests);
|
|
|
|
}
|