2017-08-09 14:25:42 +08:00
|
|
|
/* Target-dependent code for FreeBSD/aarch64.
|
|
|
|
|
|
2023-01-01 20:49:04 +08:00
|
|
|
Copyright (C) 2017-2023 Free Software Foundation, Inc.
|
2017-08-09 14:25:42 +08:00
|
|
|
|
|
|
|
|
This file is part of GDB.
|
|
|
|
|
|
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
|
|
|
it under the terms of the GNU General Public License as published by
|
|
|
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
|
|
|
(at your option) any later version.
|
|
|
|
|
|
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
|
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
|
GNU General Public License for more details.
|
|
|
|
|
|
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
|
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
|
|
|
|
|
|
#include "defs.h"
|
|
|
|
|
|
2019-04-03 10:04:24 +08:00
|
|
|
#include "gdbarch.h"
|
2019-04-07 03:38:10 +08:00
|
|
|
#include "fbsd-tdep.h"
|
|
|
|
|
#include "aarch64-tdep.h"
|
|
|
|
|
#include "aarch64-fbsd-tdep.h"
|
2022-05-04 07:05:10 +08:00
|
|
|
#include "inferior.h"
|
2017-08-09 14:25:42 +08:00
|
|
|
#include "osabi.h"
|
|
|
|
|
#include "solib-svr4.h"
|
|
|
|
|
#include "target.h"
|
2019-04-03 10:04:24 +08:00
|
|
|
#include "tramp-frame.h"
|
2019-04-07 03:38:10 +08:00
|
|
|
#include "trad-frame.h"
|
2017-08-09 14:25:42 +08:00
|
|
|
|
2019-01-29 02:16:58 +08:00
|
|
|
/* Register maps. */
|
|
|
|
|
|
|
|
|
|
static const struct regcache_map_entry aarch64_fbsd_gregmap[] =
|
|
|
|
|
{
|
|
|
|
|
{ 30, AARCH64_X0_REGNUM, 8 }, /* x0 ... x29 */
|
|
|
|
|
{ 1, AARCH64_LR_REGNUM, 8 },
|
|
|
|
|
{ 1, AARCH64_SP_REGNUM, 8 },
|
|
|
|
|
{ 1, AARCH64_PC_REGNUM, 8 },
|
|
|
|
|
{ 1, AARCH64_CPSR_REGNUM, 4 },
|
|
|
|
|
{ 0 }
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
static const struct regcache_map_entry aarch64_fbsd_fpregmap[] =
|
|
|
|
|
{
|
|
|
|
|
{ 32, AARCH64_V0_REGNUM, 16 }, /* v0 ... v31 */
|
|
|
|
|
{ 1, AARCH64_FPSR_REGNUM, 4 },
|
|
|
|
|
{ 1, AARCH64_FPCR_REGNUM, 4 },
|
|
|
|
|
{ 0 }
|
|
|
|
|
};
|
|
|
|
|
|
2022-08-23 00:04:41 +08:00
|
|
|
/* Register numbers are relative to tdep->tls_regnum_base. */
|
2022-11-23 06:21:13 +08:00
|
|
|
|
|
|
|
|
static const struct regcache_map_entry aarch64_fbsd_tls_regmap[] =
|
|
|
|
|
{
|
|
|
|
|
{ 1, 0, 8 }, /* tpidr */
|
|
|
|
|
{ 0 }
|
|
|
|
|
};
|
|
|
|
|
|
2017-08-09 14:25:42 +08:00
|
|
|
/* In a signal frame, sp points to a 'struct sigframe' which is
|
|
|
|
|
defined as:
|
|
|
|
|
|
|
|
|
|
struct sigframe {
|
|
|
|
|
siginfo_t sf_si;
|
|
|
|
|
ucontext_t sf_uc;
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
ucontext_t is defined as:
|
|
|
|
|
|
|
|
|
|
struct __ucontext {
|
|
|
|
|
sigset_t uc_sigmask;
|
|
|
|
|
mcontext_t uc_mcontext;
|
|
|
|
|
...
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
The mcontext_t contains the general purpose register set followed
|
|
|
|
|
by the floating point register set. The floating point register
|
|
|
|
|
set is only valid if the _MC_FP_VALID flag is set in mc_flags. */
|
|
|
|
|
|
|
|
|
|
#define AARCH64_SIGFRAME_UCONTEXT_OFFSET 80
|
|
|
|
|
#define AARCH64_UCONTEXT_MCONTEXT_OFFSET 16
|
|
|
|
|
#define AARCH64_MCONTEXT_FPREGS_OFFSET 272
|
|
|
|
|
#define AARCH64_MCONTEXT_FLAGS_OFFSET 800
|
|
|
|
|
#define AARCH64_MCONTEXT_FLAG_FP_VALID 0x1
|
|
|
|
|
|
|
|
|
|
/* Implement the "init" method of struct tramp_frame. */
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
aarch64_fbsd_sigframe_init (const struct tramp_frame *self,
|
2022-07-26 01:06:35 +08:00
|
|
|
frame_info_ptr this_frame,
|
2017-08-09 14:25:42 +08:00
|
|
|
struct trad_frame_cache *this_cache,
|
|
|
|
|
CORE_ADDR func)
|
|
|
|
|
{
|
|
|
|
|
struct gdbarch *gdbarch = get_frame_arch (this_frame);
|
|
|
|
|
enum bfd_endian byte_order = gdbarch_byte_order (gdbarch);
|
|
|
|
|
CORE_ADDR sp = get_frame_register_unsigned (this_frame, AARCH64_SP_REGNUM);
|
2019-01-29 02:16:58 +08:00
|
|
|
CORE_ADDR mcontext_addr
|
|
|
|
|
= (sp
|
|
|
|
|
+ AARCH64_SIGFRAME_UCONTEXT_OFFSET
|
|
|
|
|
+ AARCH64_UCONTEXT_MCONTEXT_OFFSET);
|
2017-08-09 14:25:42 +08:00
|
|
|
gdb_byte buf[4];
|
2019-01-29 02:16:58 +08:00
|
|
|
|
|
|
|
|
trad_frame_set_reg_regmap (this_cache, aarch64_fbsd_gregmap, mcontext_addr,
|
|
|
|
|
regcache_map_entry_size (aarch64_fbsd_gregmap));
|
2017-08-09 14:25:42 +08:00
|
|
|
|
|
|
|
|
if (target_read_memory (mcontext_addr + AARCH64_MCONTEXT_FLAGS_OFFSET, buf,
|
|
|
|
|
4) == 0
|
|
|
|
|
&& (extract_unsigned_integer (buf, 4, byte_order)
|
|
|
|
|
& AARCH64_MCONTEXT_FLAG_FP_VALID))
|
2019-01-29 02:16:58 +08:00
|
|
|
trad_frame_set_reg_regmap (this_cache, aarch64_fbsd_fpregmap,
|
|
|
|
|
mcontext_addr + AARCH64_MCONTEXT_FPREGS_OFFSET,
|
|
|
|
|
regcache_map_entry_size (aarch64_fbsd_fpregmap));
|
2017-08-09 14:25:42 +08:00
|
|
|
|
|
|
|
|
trad_frame_set_id (this_cache, frame_id_build (sp, func));
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static const struct tramp_frame aarch64_fbsd_sigframe =
|
|
|
|
|
{
|
|
|
|
|
SIGTRAMP_FRAME,
|
|
|
|
|
4,
|
|
|
|
|
{
|
2018-08-08 03:04:05 +08:00
|
|
|
{0x910003e0, ULONGEST_MAX}, /* mov x0, sp */
|
|
|
|
|
{0x91014000, ULONGEST_MAX}, /* add x0, x0, #SF_UC */
|
|
|
|
|
{0xd2803428, ULONGEST_MAX}, /* mov x8, #SYS_sigreturn */
|
|
|
|
|
{0xd4000001, ULONGEST_MAX}, /* svc 0x0 */
|
|
|
|
|
{TRAMP_SENTINEL_INSN, ULONGEST_MAX}
|
2017-08-09 14:25:42 +08:00
|
|
|
},
|
|
|
|
|
aarch64_fbsd_sigframe_init
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
/* Register set definitions. */
|
|
|
|
|
|
|
|
|
|
const struct regset aarch64_fbsd_gregset =
|
|
|
|
|
{
|
|
|
|
|
aarch64_fbsd_gregmap,
|
|
|
|
|
regcache_supply_regset, regcache_collect_regset
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
const struct regset aarch64_fbsd_fpregset =
|
|
|
|
|
{
|
|
|
|
|
aarch64_fbsd_fpregmap,
|
|
|
|
|
regcache_supply_regset, regcache_collect_regset
|
|
|
|
|
};
|
|
|
|
|
|
2022-11-23 06:21:13 +08:00
|
|
|
static void
|
|
|
|
|
aarch64_fbsd_supply_tls_regset (const struct regset *regset,
|
|
|
|
|
struct regcache *regcache,
|
|
|
|
|
int regnum, const void *buf, size_t size)
|
|
|
|
|
{
|
|
|
|
|
struct gdbarch *gdbarch = regcache->arch ();
|
|
|
|
|
aarch64_gdbarch_tdep *tdep = gdbarch_tdep<aarch64_gdbarch_tdep> (gdbarch);
|
|
|
|
|
|
2022-08-23 00:04:41 +08:00
|
|
|
regcache->supply_regset (regset, tdep->tls_regnum_base, regnum, buf, size);
|
2022-11-23 06:21:13 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
aarch64_fbsd_collect_tls_regset (const struct regset *regset,
|
|
|
|
|
const struct regcache *regcache,
|
|
|
|
|
int regnum, void *buf, size_t size)
|
|
|
|
|
{
|
|
|
|
|
struct gdbarch *gdbarch = regcache->arch ();
|
|
|
|
|
aarch64_gdbarch_tdep *tdep = gdbarch_tdep<aarch64_gdbarch_tdep> (gdbarch);
|
|
|
|
|
|
2022-08-23 00:04:41 +08:00
|
|
|
regcache->collect_regset (regset, tdep->tls_regnum_base, regnum, buf, size);
|
2022-11-23 06:21:13 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
const struct regset aarch64_fbsd_tls_regset =
|
|
|
|
|
{
|
|
|
|
|
aarch64_fbsd_tls_regmap,
|
|
|
|
|
aarch64_fbsd_supply_tls_regset, aarch64_fbsd_collect_tls_regset
|
|
|
|
|
};
|
|
|
|
|
|
2020-01-23 22:52:05 +08:00
|
|
|
/* Implement the "iterate_over_regset_sections" gdbarch method. */
|
2017-08-09 14:25:42 +08:00
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
aarch64_fbsd_iterate_over_regset_sections (struct gdbarch *gdbarch,
|
|
|
|
|
iterate_over_regset_sections_cb *cb,
|
|
|
|
|
void *cb_data,
|
|
|
|
|
const struct regcache *regcache)
|
|
|
|
|
{
|
gdb: move the type cast into gdbarch_tdep
I built GDB for all targets on a x86-64/GNU-Linux system, and
then (accidentally) passed GDB a RISC-V binary, and asked GDB to "run"
the binary on the native target. I got this error:
(gdb) show architecture
The target architecture is set to "auto" (currently "i386").
(gdb) file /tmp/hello.rv32.exe
Reading symbols from /tmp/hello.rv32.exe...
(gdb) show architecture
The target architecture is set to "auto" (currently "riscv:rv32").
(gdb) run
Starting program: /tmp/hello.rv32.exe
../../src/gdb/i387-tdep.c:596: internal-error: i387_supply_fxsave: Assertion `tdep->st0_regnum >= I386_ST0_REGNUM' failed.
What's going on here is this; initially the architecture is i386, this
is based on the default architecture, which is set based on the native
target. After loading the RISC-V executable the architecture of the
current inferior is updated based on the architecture of the
executable.
When we "run", GDB does a fork & exec, with the inferior being
controlled through ptrace. GDB sees an initial stop from the inferior
as soon as the inferior comes to life. In response to this stop GDB
ends up calling save_stop_reason (linux-nat.c), which ends up trying
to read register from the inferior, to do this we end up calling
target_ops::fetch_registers, which, for the x86-64 native target,
calls amd64_linux_nat_target::fetch_registers.
After this I eventually end up in i387_supply_fxsave, different x86
based targets will end in different functions to fetch registers, but
it doesn't really matter which function we end up in, the problem is
this line, which is repeated in many places:
i386_gdbarch_tdep *tdep = (i386_gdbarch_tdep *) gdbarch_tdep (arch);
The problem here is that the ARCH in this line comes from the current
inferior, which, as we discussed above, will be a RISC-V gdbarch, the
tdep field will actually be of type riscv_gdbarch_tdep, not
i386_gdbarch_tdep. After this cast we are relying on undefined
behaviour, in my case I happen to trigger an assert, but this might
not always be the case.
The thing I tried that exposed this problem was of course, trying to
start an executable of the wrong architecture on a native target. I
don't think that the correct solution for this problem is to detect,
at the point of cast, that the gdbarch_tdep object is of the wrong
type, but, I did wonder, is there a way that we could protect
ourselves from incorrectly casting the gdbarch_tdep object?
I think that there is something we can do here, and this commit is the
first step in that direction, though no actual check is added by this
commit.
This commit can be split into two parts:
(1) In gdbarch.h and arch-utils.c. In these files I have modified
gdbarch_tdep (the function) so that it now takes a template argument,
like this:
template<typename TDepType>
static inline TDepType *
gdbarch_tdep (struct gdbarch *gdbarch)
{
struct gdbarch_tdep *tdep = gdbarch_tdep_1 (gdbarch);
return static_cast<TDepType *> (tdep);
}
After this change we are no better protected, but the cast is now
done within the gdbarch_tdep function rather than at the call sites,
this leads to the second, much larger change in this commit,
(2) Everywhere gdbarch_tdep is called, we make changes like this:
- i386_gdbarch_tdep *tdep = (i386_gdbarch_tdep *) gdbarch_tdep (arch);
+ i386_gdbarch_tdep *tdep = gdbarch_tdep<i386_gdbarch_tdep> (arch);
There should be no functional change after this commit.
In the next commit I will build on this change to add an assertion in
gdbarch_tdep that checks we are casting to the correct type.
2022-05-19 20:20:17 +08:00
|
|
|
aarch64_gdbarch_tdep *tdep = gdbarch_tdep<aarch64_gdbarch_tdep> (gdbarch);
|
2022-05-04 07:05:10 +08:00
|
|
|
|
2018-08-13 17:04:11 +08:00
|
|
|
cb (".reg", AARCH64_FBSD_SIZEOF_GREGSET, AARCH64_FBSD_SIZEOF_GREGSET,
|
|
|
|
|
&aarch64_fbsd_gregset, NULL, cb_data);
|
|
|
|
|
cb (".reg2", AARCH64_FBSD_SIZEOF_FPREGSET, AARCH64_FBSD_SIZEOF_FPREGSET,
|
|
|
|
|
&aarch64_fbsd_fpregset, NULL, cb_data);
|
2022-05-04 07:05:10 +08:00
|
|
|
|
|
|
|
|
if (tdep->has_tls ())
|
2022-11-23 06:21:13 +08:00
|
|
|
cb (".reg-aarch-tls", AARCH64_FBSD_SIZEOF_TLSREGSET,
|
|
|
|
|
AARCH64_FBSD_SIZEOF_TLSREGSET, &aarch64_fbsd_tls_regset,
|
|
|
|
|
"TLS register", cb_data);
|
2022-05-04 07:05:10 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Implement the "core_read_description" gdbarch method. */
|
|
|
|
|
|
|
|
|
|
static const struct target_desc *
|
|
|
|
|
aarch64_fbsd_core_read_description (struct gdbarch *gdbarch,
|
|
|
|
|
struct target_ops *target, bfd *abfd)
|
|
|
|
|
{
|
|
|
|
|
asection *tls = bfd_get_section_by_name (abfd, ".reg-aarch-tls");
|
|
|
|
|
|
2022-05-19 04:32:04 +08:00
|
|
|
aarch64_features features;
|
2022-08-23 00:04:41 +08:00
|
|
|
features.tls = tls != nullptr? 1 : 0;
|
2022-05-19 04:32:04 +08:00
|
|
|
|
|
|
|
|
return aarch64_read_description (features);
|
2017-08-09 14:25:42 +08:00
|
|
|
}
|
|
|
|
|
|
2022-05-04 07:05:10 +08:00
|
|
|
/* Implement the get_thread_local_address gdbarch method. */
|
|
|
|
|
|
|
|
|
|
static CORE_ADDR
|
|
|
|
|
aarch64_fbsd_get_thread_local_address (struct gdbarch *gdbarch, ptid_t ptid,
|
|
|
|
|
CORE_ADDR lm_addr, CORE_ADDR offset)
|
|
|
|
|
{
|
gdb: move the type cast into gdbarch_tdep
I built GDB for all targets on a x86-64/GNU-Linux system, and
then (accidentally) passed GDB a RISC-V binary, and asked GDB to "run"
the binary on the native target. I got this error:
(gdb) show architecture
The target architecture is set to "auto" (currently "i386").
(gdb) file /tmp/hello.rv32.exe
Reading symbols from /tmp/hello.rv32.exe...
(gdb) show architecture
The target architecture is set to "auto" (currently "riscv:rv32").
(gdb) run
Starting program: /tmp/hello.rv32.exe
../../src/gdb/i387-tdep.c:596: internal-error: i387_supply_fxsave: Assertion `tdep->st0_regnum >= I386_ST0_REGNUM' failed.
What's going on here is this; initially the architecture is i386, this
is based on the default architecture, which is set based on the native
target. After loading the RISC-V executable the architecture of the
current inferior is updated based on the architecture of the
executable.
When we "run", GDB does a fork & exec, with the inferior being
controlled through ptrace. GDB sees an initial stop from the inferior
as soon as the inferior comes to life. In response to this stop GDB
ends up calling save_stop_reason (linux-nat.c), which ends up trying
to read register from the inferior, to do this we end up calling
target_ops::fetch_registers, which, for the x86-64 native target,
calls amd64_linux_nat_target::fetch_registers.
After this I eventually end up in i387_supply_fxsave, different x86
based targets will end in different functions to fetch registers, but
it doesn't really matter which function we end up in, the problem is
this line, which is repeated in many places:
i386_gdbarch_tdep *tdep = (i386_gdbarch_tdep *) gdbarch_tdep (arch);
The problem here is that the ARCH in this line comes from the current
inferior, which, as we discussed above, will be a RISC-V gdbarch, the
tdep field will actually be of type riscv_gdbarch_tdep, not
i386_gdbarch_tdep. After this cast we are relying on undefined
behaviour, in my case I happen to trigger an assert, but this might
not always be the case.
The thing I tried that exposed this problem was of course, trying to
start an executable of the wrong architecture on a native target. I
don't think that the correct solution for this problem is to detect,
at the point of cast, that the gdbarch_tdep object is of the wrong
type, but, I did wonder, is there a way that we could protect
ourselves from incorrectly casting the gdbarch_tdep object?
I think that there is something we can do here, and this commit is the
first step in that direction, though no actual check is added by this
commit.
This commit can be split into two parts:
(1) In gdbarch.h and arch-utils.c. In these files I have modified
gdbarch_tdep (the function) so that it now takes a template argument,
like this:
template<typename TDepType>
static inline TDepType *
gdbarch_tdep (struct gdbarch *gdbarch)
{
struct gdbarch_tdep *tdep = gdbarch_tdep_1 (gdbarch);
return static_cast<TDepType *> (tdep);
}
After this change we are no better protected, but the cast is now
done within the gdbarch_tdep function rather than at the call sites,
this leads to the second, much larger change in this commit,
(2) Everywhere gdbarch_tdep is called, we make changes like this:
- i386_gdbarch_tdep *tdep = (i386_gdbarch_tdep *) gdbarch_tdep (arch);
+ i386_gdbarch_tdep *tdep = gdbarch_tdep<i386_gdbarch_tdep> (arch);
There should be no functional change after this commit.
In the next commit I will build on this change to add an assertion in
gdbarch_tdep that checks we are casting to the correct type.
2022-05-19 20:20:17 +08:00
|
|
|
aarch64_gdbarch_tdep *tdep = gdbarch_tdep<aarch64_gdbarch_tdep> (gdbarch);
|
2022-05-04 07:05:10 +08:00
|
|
|
struct regcache *regcache;
|
|
|
|
|
|
gdb: remove regcache's address space
While looking at the regcache code, I noticed that the address space
(passed to regcache when constructing it, and available through
regcache::aspace) wasn't relevant for the regcache itself. Callers of
regcache::aspace use that method because it appears to be a convenient
way of getting the address space for a thread, if you already have the
regcache. But there is always another way to get the address space, as
the callers pretty much always know which thread they are dealing with.
The regcache code itself doesn't use the address space.
This patch removes anything related to address_space from the regcache
code, and updates callers to get it from the thread in context. This
removes a bit of unnecessary complexity from the regcache code.
The current get_thread_arch_regcache function gets an address_space for
the given thread using the target_thread_address_space function (which
calls the target_ops::thread_address_space method). This suggest that
there might have been the intention of supporting per-thread address
spaces. But digging through the history, I did not find any such case.
Maybe this method was just added because we needed a way to get an
address space from a ptid (because constructing a regcache required an
address space), and this seemed like the right way to do it, I don't
know.
The only implementations of thread_address_space and
process_stratum_target::thread_address_space and
linux_nat_target::thread_address_space, which essentially just return
the inferior's address space. And thread_address_space is only used in
the current get_thread_arch_regcache, which gets removed. So, I think
that the thread_address_space target method can be removed, and we can
assume that it's fine to use the inferior's address space everywhere.
Callers of regcache::aspace are updated to get the address space from
the relevant inferior, either using some context they already know
about, or in last resort using the current global context.
So, to summarize:
- remove everything in regcache related to address spaces
- in particular, remove get_thread_arch_regcache, and rename
get_thread_arch_aspace_regcache to get_thread_arch_regcache
- remove target_ops::thread_address_space, and
target_thread_address_space
- adjust all users of regcache::aspace to get the address space another
way
Change-Id: I04fd41b22c83fe486522af7851c75bcfb31c88c7
2023-11-18 03:55:58 +08:00
|
|
|
regcache = get_thread_arch_regcache (current_inferior (), ptid, gdbarch);
|
2022-05-04 07:05:10 +08:00
|
|
|
|
2022-08-23 00:04:41 +08:00
|
|
|
target_fetch_registers (regcache, tdep->tls_regnum_base);
|
2022-05-04 07:05:10 +08:00
|
|
|
|
|
|
|
|
ULONGEST tpidr;
|
2022-08-23 00:04:41 +08:00
|
|
|
if (regcache->cooked_read (tdep->tls_regnum_base, &tpidr) != REG_VALID)
|
2022-05-04 07:05:10 +08:00
|
|
|
error (_("Unable to fetch %%tpidr"));
|
|
|
|
|
|
|
|
|
|
/* %tpidr points to the TCB whose first member is the dtv
|
|
|
|
|
pointer. */
|
|
|
|
|
CORE_ADDR dtv_addr = tpidr;
|
|
|
|
|
return fbsd_get_thread_local_address (gdbarch, dtv_addr, lm_addr, offset);
|
|
|
|
|
}
|
|
|
|
|
|
2017-08-09 14:25:42 +08:00
|
|
|
/* Implement the 'init_osabi' method of struct gdb_osabi_handler. */
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
aarch64_fbsd_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
|
|
|
|
|
{
|
gdb: move the type cast into gdbarch_tdep
I built GDB for all targets on a x86-64/GNU-Linux system, and
then (accidentally) passed GDB a RISC-V binary, and asked GDB to "run"
the binary on the native target. I got this error:
(gdb) show architecture
The target architecture is set to "auto" (currently "i386").
(gdb) file /tmp/hello.rv32.exe
Reading symbols from /tmp/hello.rv32.exe...
(gdb) show architecture
The target architecture is set to "auto" (currently "riscv:rv32").
(gdb) run
Starting program: /tmp/hello.rv32.exe
../../src/gdb/i387-tdep.c:596: internal-error: i387_supply_fxsave: Assertion `tdep->st0_regnum >= I386_ST0_REGNUM' failed.
What's going on here is this; initially the architecture is i386, this
is based on the default architecture, which is set based on the native
target. After loading the RISC-V executable the architecture of the
current inferior is updated based on the architecture of the
executable.
When we "run", GDB does a fork & exec, with the inferior being
controlled through ptrace. GDB sees an initial stop from the inferior
as soon as the inferior comes to life. In response to this stop GDB
ends up calling save_stop_reason (linux-nat.c), which ends up trying
to read register from the inferior, to do this we end up calling
target_ops::fetch_registers, which, for the x86-64 native target,
calls amd64_linux_nat_target::fetch_registers.
After this I eventually end up in i387_supply_fxsave, different x86
based targets will end in different functions to fetch registers, but
it doesn't really matter which function we end up in, the problem is
this line, which is repeated in many places:
i386_gdbarch_tdep *tdep = (i386_gdbarch_tdep *) gdbarch_tdep (arch);
The problem here is that the ARCH in this line comes from the current
inferior, which, as we discussed above, will be a RISC-V gdbarch, the
tdep field will actually be of type riscv_gdbarch_tdep, not
i386_gdbarch_tdep. After this cast we are relying on undefined
behaviour, in my case I happen to trigger an assert, but this might
not always be the case.
The thing I tried that exposed this problem was of course, trying to
start an executable of the wrong architecture on a native target. I
don't think that the correct solution for this problem is to detect,
at the point of cast, that the gdbarch_tdep object is of the wrong
type, but, I did wonder, is there a way that we could protect
ourselves from incorrectly casting the gdbarch_tdep object?
I think that there is something we can do here, and this commit is the
first step in that direction, though no actual check is added by this
commit.
This commit can be split into two parts:
(1) In gdbarch.h and arch-utils.c. In these files I have modified
gdbarch_tdep (the function) so that it now takes a template argument,
like this:
template<typename TDepType>
static inline TDepType *
gdbarch_tdep (struct gdbarch *gdbarch)
{
struct gdbarch_tdep *tdep = gdbarch_tdep_1 (gdbarch);
return static_cast<TDepType *> (tdep);
}
After this change we are no better protected, but the cast is now
done within the gdbarch_tdep function rather than at the call sites,
this leads to the second, much larger change in this commit,
(2) Everywhere gdbarch_tdep is called, we make changes like this:
- i386_gdbarch_tdep *tdep = (i386_gdbarch_tdep *) gdbarch_tdep (arch);
+ i386_gdbarch_tdep *tdep = gdbarch_tdep<i386_gdbarch_tdep> (arch);
There should be no functional change after this commit.
In the next commit I will build on this change to add an assertion in
gdbarch_tdep that checks we are casting to the correct type.
2022-05-19 20:20:17 +08:00
|
|
|
aarch64_gdbarch_tdep *tdep = gdbarch_tdep<aarch64_gdbarch_tdep> (gdbarch);
|
2017-08-09 14:25:42 +08:00
|
|
|
|
|
|
|
|
/* Generic FreeBSD support. */
|
|
|
|
|
fbsd_init_abi (info, gdbarch);
|
|
|
|
|
|
|
|
|
|
set_solib_svr4_fetch_link_map_offsets (gdbarch,
|
|
|
|
|
svr4_lp64_fetch_link_map_offsets);
|
|
|
|
|
|
|
|
|
|
tramp_frame_prepend_unwinder (gdbarch, &aarch64_fbsd_sigframe);
|
|
|
|
|
|
|
|
|
|
/* Enable longjmp. */
|
|
|
|
|
tdep->jb_pc = 13;
|
|
|
|
|
|
|
|
|
|
set_gdbarch_iterate_over_regset_sections
|
|
|
|
|
(gdbarch, aarch64_fbsd_iterate_over_regset_sections);
|
2022-05-04 07:05:10 +08:00
|
|
|
set_gdbarch_core_read_description (gdbarch,
|
|
|
|
|
aarch64_fbsd_core_read_description);
|
2022-05-04 07:05:10 +08:00
|
|
|
|
|
|
|
|
if (tdep->has_tls ())
|
|
|
|
|
{
|
|
|
|
|
set_gdbarch_fetch_tls_load_module_address (gdbarch,
|
|
|
|
|
svr4_fetch_objfile_link_map);
|
|
|
|
|
set_gdbarch_get_thread_local_address
|
|
|
|
|
(gdbarch, aarch64_fbsd_get_thread_local_address);
|
|
|
|
|
}
|
2017-08-09 14:25:42 +08:00
|
|
|
}
|
|
|
|
|
|
2020-01-14 03:01:38 +08:00
|
|
|
void _initialize_aarch64_fbsd_tdep ();
|
2017-08-09 14:25:42 +08:00
|
|
|
void
|
2020-01-14 03:01:38 +08:00
|
|
|
_initialize_aarch64_fbsd_tdep ()
|
2017-08-09 14:25:42 +08:00
|
|
|
{
|
|
|
|
|
gdbarch_register_osabi (bfd_arch_aarch64, 0, GDB_OSABI_FREEBSD,
|
|
|
|
|
aarch64_fbsd_init_abi);
|
|
|
|
|
}
|
