gdb: Handle W and X remote packets without giving a warning
In this commit:
commit 24ed6739b699f329c2c45aedee5f8c7d2f54e493
Date: Thu Jan 30 14:35:40 2020 +0000
gdb/remote: Restore support for 'S' stop reply packet
A regression was introduced such that the W and X packets would give a
warning in some cases. The warning was:
warning: multi-threaded target stopped without sending a thread-id, using first non-exited thread
This problem would arise when:
1. The multi-process extensions to the remote protocol were not
being used, and
2. The inferior has multiple threads.
In this case when the W (or X) packet arrives the ptid of the
stop_reply is set to null_ptid, then when we arrive in
process_stop_reply GDB spots that we have multiple non-exited theads,
but the stop event didn't specify a thread-id.
The problem with this is that the W (and X) packets are actually
process wide events, they apply to all threads. So not specifying a
thread-id is not a problem, in fact, the best these packets allow is
for the remote to specify a process-id, not a thread-id.
If we look at how the W (and X) packets deal with a specified
process-id, then what happens is GDB sets to stop_reply ptid to a
value which indicates all threads in the process, this is done by
creating a value `ptid_t (pid)`, which sets the pid field of the
ptid_t, but leaves the tid field as 0, indicating all threads.
So, this commit does the same thing for the case where there is not
process-id specified. In process_stop_reply we not distinguish
between stop events that apply to all threads, and those that apply to
only one. If the stop event applies to only one thread then we treat
it as before. If, however, the stop event applies to all threads,
then we find the first non-exited thread, and use the pid from this
thread to create a `ptid_t (pid)` value.
If the target has multiple inferiors, and receives a process wide
event without specifying a process-id GDB now gives this warning:
warning: multi-inferior target stopped without sending a process-id, using first non-exited inferior
gdb/ChangeLog:
* remote.c (remote_target::process_stop_reply): Handle events for
all threads differently.
gdb/testsuite/ChangeLog:
* gdb.server/exit-multiple-threads.c: New file.
* gdb.server/exit-multiple-threads.exp: New file.
2020-03-11 20:30:13 +08:00
|
|
|
/* This testcase is part of GDB, the GNU debugger.
|
|
|
|
|
2022-01-01 22:56:03 +08:00
|
|
|
Copyright 2020-2022 Free Software Foundation, Inc.
|
gdb: Handle W and X remote packets without giving a warning
In this commit:
commit 24ed6739b699f329c2c45aedee5f8c7d2f54e493
Date: Thu Jan 30 14:35:40 2020 +0000
gdb/remote: Restore support for 'S' stop reply packet
A regression was introduced such that the W and X packets would give a
warning in some cases. The warning was:
warning: multi-threaded target stopped without sending a thread-id, using first non-exited thread
This problem would arise when:
1. The multi-process extensions to the remote protocol were not
being used, and
2. The inferior has multiple threads.
In this case when the W (or X) packet arrives the ptid of the
stop_reply is set to null_ptid, then when we arrive in
process_stop_reply GDB spots that we have multiple non-exited theads,
but the stop event didn't specify a thread-id.
The problem with this is that the W (and X) packets are actually
process wide events, they apply to all threads. So not specifying a
thread-id is not a problem, in fact, the best these packets allow is
for the remote to specify a process-id, not a thread-id.
If we look at how the W (and X) packets deal with a specified
process-id, then what happens is GDB sets to stop_reply ptid to a
value which indicates all threads in the process, this is done by
creating a value `ptid_t (pid)`, which sets the pid field of the
ptid_t, but leaves the tid field as 0, indicating all threads.
So, this commit does the same thing for the case where there is not
process-id specified. In process_stop_reply we not distinguish
between stop events that apply to all threads, and those that apply to
only one. If the stop event applies to only one thread then we treat
it as before. If, however, the stop event applies to all threads,
then we find the first non-exited thread, and use the pid from this
thread to create a `ptid_t (pid)` value.
If the target has multiple inferiors, and receives a process wide
event without specifying a process-id GDB now gives this warning:
warning: multi-inferior target stopped without sending a process-id, using first non-exited inferior
gdb/ChangeLog:
* remote.c (remote_target::process_stop_reply): Handle events for
all threads differently.
gdb/testsuite/ChangeLog:
* gdb.server/exit-multiple-threads.c: New file.
* gdb.server/exit-multiple-threads.exp: New file.
2020-03-11 20:30:13 +08:00
|
|
|
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
|
|
it under the terms of the GNU General Public License as published by
|
|
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
|
|
(at your option) any later version.
|
|
|
|
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
GNU General Public License for more details.
|
|
|
|
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
|
|
|
|
#include <pthread.h>
|
|
|
|
#include <sys/types.h>
|
|
|
|
#include <stdio.h>
|
|
|
|
#include <unistd.h>
|
|
|
|
#include <stdlib.h>
|
|
|
|
#include <pthread.h>
|
|
|
|
|
|
|
|
/* The number of threads to create. */
|
|
|
|
int thread_count = 3;
|
|
|
|
|
|
|
|
/* Counter accessed from threads to ensure that all threads have been
|
|
|
|
started. Is initialised to THREAD_COUNT and each thread decrements it
|
|
|
|
upon startup. */
|
|
|
|
volatile int counter;
|
|
|
|
|
|
|
|
/* Lock guarding COUNTER. */
|
|
|
|
pthread_mutex_t counter_mutex = PTHREAD_MUTEX_INITIALIZER;
|
|
|
|
|
|
|
|
/* Is initialised with our pid, GDB will read this. */
|
|
|
|
pid_t global_pid;
|
|
|
|
|
|
|
|
/* Just somewhere to put a breakpoint. */
|
|
|
|
static void
|
|
|
|
breakpt ()
|
|
|
|
{
|
|
|
|
/* Nothing. */
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Thread safe decrement of the COUNTER global. */
|
|
|
|
static void
|
|
|
|
decrement_counter ()
|
|
|
|
{
|
|
|
|
if (pthread_mutex_lock (&counter_mutex) != 0)
|
|
|
|
abort ();
|
|
|
|
--counter;
|
|
|
|
if (pthread_mutex_unlock (&counter_mutex) != 0)
|
|
|
|
abort ();
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Thread safe read of the COUNTER global. */
|
|
|
|
static int
|
|
|
|
read_counter ()
|
|
|
|
{
|
|
|
|
int val;
|
|
|
|
|
|
|
|
if (pthread_mutex_lock (&counter_mutex) != 0)
|
|
|
|
abort ();
|
|
|
|
val = counter;
|
|
|
|
if (pthread_mutex_unlock (&counter_mutex) != 0)
|
|
|
|
abort ();
|
|
|
|
|
|
|
|
return val;
|
|
|
|
}
|
|
|
|
|
|
|
|
#if defined DO_EXIT_TEST
|
|
|
|
|
|
|
|
/* Thread entry point. ARG is a pointer to a single integer, the ID for
|
|
|
|
this thread numbered 1 to THREAD_COUNT (a global). */
|
|
|
|
static void *
|
|
|
|
thread_worker_exiting (void *arg)
|
|
|
|
{
|
|
|
|
int id;
|
|
|
|
|
|
|
|
id = *((int *) arg);
|
|
|
|
|
|
|
|
decrement_counter ();
|
|
|
|
|
|
|
|
if (id != thread_count)
|
|
|
|
{
|
|
|
|
int i;
|
|
|
|
|
|
|
|
/* All threads except the last one will wait here while the test is
|
|
|
|
carried out. Don't wait forever though, just in case the test
|
|
|
|
goes wrong. */
|
|
|
|
for (i = 0; i < 60; ++i)
|
|
|
|
sleep (1);
|
|
|
|
}
|
|
|
|
else
|
|
|
|
{
|
|
|
|
/* The last thread waits here until all other threads have been
|
|
|
|
created. */
|
|
|
|
while (read_counter () > 0)
|
|
|
|
sleep (1);
|
|
|
|
|
|
|
|
/* Hit the breakpoint so GDB can stop. */
|
|
|
|
breakpt ();
|
|
|
|
|
|
|
|
/* And exit all threads. */
|
|
|
|
exit (0);
|
|
|
|
}
|
|
|
|
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
#define thread_worker thread_worker_exiting
|
|
|
|
|
|
|
|
#elif defined DO_SIGNAL_TEST
|
|
|
|
|
|
|
|
/* Thread entry point. ARG is a pointer to a single integer, the ID for
|
|
|
|
this thread numbered 1 to THREAD_COUNT (a global). */
|
|
|
|
static void *
|
|
|
|
thread_worker_signalling (void *arg)
|
|
|
|
{
|
|
|
|
int i, id;
|
|
|
|
|
|
|
|
id = *((int *) arg);
|
|
|
|
|
|
|
|
decrement_counter ();
|
|
|
|
|
|
|
|
if (id == thread_count)
|
|
|
|
{
|
|
|
|
/* The last thread waits here until all other threads have been
|
|
|
|
created. */
|
|
|
|
while (read_counter () > 0)
|
|
|
|
sleep (1);
|
|
|
|
|
|
|
|
/* Hit the breakpoint so GDB can stop. */
|
|
|
|
breakpt ();
|
|
|
|
}
|
|
|
|
|
|
|
|
/* All threads wait here while the testsuite sends us a signal. Don't
|
|
|
|
block forever though, just in case the test goes wrong. */
|
|
|
|
for (i = 0; i < 60; ++i)
|
|
|
|
sleep (1);
|
|
|
|
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
#define thread_worker thread_worker_signalling
|
|
|
|
|
|
|
|
#else
|
|
|
|
|
|
|
|
#error "Compile with DO_EXIT_TEST or DO_SIGNAL_TEST defined"
|
|
|
|
|
|
|
|
#endif
|
|
|
|
|
|
|
|
struct thread_info
|
|
|
|
{
|
|
|
|
pthread_t thread;
|
|
|
|
int id;
|
|
|
|
};
|
|
|
|
|
|
|
|
int
|
|
|
|
main ()
|
|
|
|
{
|
|
|
|
int i, max = thread_count;
|
|
|
|
|
|
|
|
/* Put the pid somewhere easy for GDB to read. */
|
|
|
|
global_pid = getpid ();
|
|
|
|
|
|
|
|
/* Space to hold all of the thread_info objects. */
|
|
|
|
struct thread_info *info = malloc (sizeof (struct thread_info) * max);
|
|
|
|
if (info == NULL)
|
|
|
|
abort ();
|
|
|
|
|
|
|
|
/* Initialise the counter. Don't do this under lock as we only have the
|
|
|
|
main thread at this point. */
|
|
|
|
counter = thread_count;
|
|
|
|
|
|
|
|
/* Create all of the threads. */
|
|
|
|
for (i = 0; i < max; ++i)
|
|
|
|
{
|
|
|
|
struct thread_info *thr = &info[i];
|
|
|
|
thr->id = i + 1;
|
|
|
|
if (pthread_create (&thr->thread, NULL, thread_worker, &thr->id) != 0)
|
|
|
|
abort ();
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Gather in all of the threads. This never completes, as the
|
|
|
|
final thread created will exit the process, and all of the other
|
|
|
|
threads block forever. Still, it gives the main thread something to
|
|
|
|
do. */
|
|
|
|
for (i = 0; i < max; ++i)
|
|
|
|
{
|
|
|
|
struct thread_info *thr = &info[i];
|
|
|
|
if (pthread_join (thr->thread, NULL) != 0)
|
|
|
|
abort ();
|
|
|
|
}
|
|
|
|
|
|
|
|
free (info);
|
|
|
|
|
|
|
|
/* Return non-zero. We should never get here, but if we do make sure we
|
|
|
|
indicate something has gone wrong. */
|
|
|
|
return 1;
|
|
|
|
}
|