2020-02-27 06:40:49 +08:00
|
|
|
/* debuginfod utilities for GDB.
|
2022-01-01 22:56:03 +08:00
|
|
|
Copyright (C) 2020-2022 Free Software Foundation, Inc.
|
2020-02-27 06:40:49 +08:00
|
|
|
|
|
|
|
This file is part of GDB.
|
|
|
|
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
|
|
it under the terms of the GNU General Public License as published by
|
|
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
|
|
(at your option) any later version.
|
|
|
|
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
GNU General Public License for more details.
|
|
|
|
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
|
|
|
|
#include "defs.h"
|
2022-05-04 07:17:31 +08:00
|
|
|
#include "diagnostics.h"
|
2020-02-29 21:33:35 +08:00
|
|
|
#include <errno.h>
|
2020-02-27 06:40:49 +08:00
|
|
|
#include "gdbsupport/scoped_fd.h"
|
|
|
|
#include "debuginfod-support.h"
|
2020-12-17 01:18:40 +08:00
|
|
|
#include "gdbsupport/gdb_optional.h"
|
2021-10-30 07:55:57 +08:00
|
|
|
#include "cli/cli-cmds.h"
|
|
|
|
#include "cli/cli-style.h"
|
2021-11-30 03:58:38 +08:00
|
|
|
#include "target.h"
|
2021-10-30 07:55:57 +08:00
|
|
|
|
|
|
|
/* Set/show debuginfod commands. */
|
|
|
|
static cmd_list_element *set_debuginfod_prefix_list;
|
|
|
|
static cmd_list_element *show_debuginfod_prefix_list;
|
|
|
|
|
|
|
|
static const char debuginfod_on[] = "on";
|
|
|
|
static const char debuginfod_off[] = "off";
|
|
|
|
static const char debuginfod_ask[] = "ask";
|
|
|
|
|
gdb: rework "set debuginfod" commands
As discussed here [1], do some re-work in the "set debuginfod commands".
First, use "set debuginfod enabled on/off/ask" instead of "set
debuginfod on/off/ask". This is more MI-friendly, and it gives an
output that makes more sense in "info set", for example.
Then, make the show commands not call "error" when debuginfod support is
not compiled in. This makes the commands "show" and "show debuginfod"
stop early, breaking gdb.base/default.exp:
Running /home/smarchi/src/binutils-gdb/gdb/testsuite/gdb.base/default.exp ...
FAIL: gdb.base/default.exp: info set
FAIL: gdb.base/default.exp: show
- Make the "debuginfod enabled" setting default to "off" when debuginfod
support is not compiled in, and "ask" otherwise.
- Make the setter of "debuginfod enabled" error out when debuginfod
support is not compiled in, so that "debuginfod enabled" will always
remain "off" in that case.
- Make the setter of "debuginfod verbose" work in any case. I don't
see the harm in letting the user change that setting, since the user will
hit an error if they try to enable the use of debuginfod.
- I would do the same for the "debuginfod urls" setter, but because
this one needs to see the DEBUGINFOD_URLS_ENV_VAR macro, provided by
libdebuginfod, I made that one error out as well if debuginfod
support is not compiled it (otherwise, I would have left it like
"debuginfod verbose". Alternatively, we could hard-code
"DEBUGINFOD_URLS" in the code (in fact, it was prior to this patch,
but I think it was an oversight, as other spots use
DEBUGINFOD_URLS_ENV_VAR), or use a dummy string to store the setting,
but I don't really see the value in that.
Rename debuginfod_enable to debuginfod_enabled, just so it matches the
setting name.
[1] https://sourceware.org/pipermail/gdb-patches/2021-October/182937.html
Change-Id: I45fdb2993f668226a5639228951362b7800f09d5
Co-Authored-By: Aaron Merey <amerey@redhat.com>
2021-11-03 00:21:31 +08:00
|
|
|
static const char *debuginfod_enabled_enum[] =
|
|
|
|
{
|
|
|
|
debuginfod_on,
|
|
|
|
debuginfod_off,
|
|
|
|
debuginfod_ask,
|
|
|
|
nullptr
|
|
|
|
};
|
|
|
|
|
|
|
|
static const char *debuginfod_enabled =
|
|
|
|
#if defined(HAVE_LIBDEBUGINFOD)
|
|
|
|
debuginfod_ask;
|
|
|
|
#else
|
|
|
|
debuginfod_off;
|
|
|
|
#endif
|
|
|
|
|
|
|
|
static unsigned int debuginfod_verbose = 1;
|
2020-02-27 06:40:49 +08:00
|
|
|
|
|
|
|
#ifndef HAVE_LIBDEBUGINFOD
|
|
|
|
scoped_fd
|
|
|
|
debuginfod_source_query (const unsigned char *build_id,
|
|
|
|
int build_id_len,
|
|
|
|
const char *srcpath,
|
|
|
|
gdb::unique_xmalloc_ptr<char> *destname)
|
|
|
|
{
|
|
|
|
return scoped_fd (-ENOSYS);
|
|
|
|
}
|
|
|
|
|
|
|
|
scoped_fd
|
|
|
|
debuginfod_debuginfo_query (const unsigned char *build_id,
|
|
|
|
int build_id_len,
|
|
|
|
const char *filename,
|
|
|
|
gdb::unique_xmalloc_ptr<char> *destname)
|
|
|
|
{
|
|
|
|
return scoped_fd (-ENOSYS);
|
|
|
|
}
|
2021-10-30 07:55:57 +08:00
|
|
|
|
2022-03-03 09:00:59 +08:00
|
|
|
scoped_fd
|
|
|
|
debuginfod_exec_query (const unsigned char *build_id,
|
|
|
|
int build_id_len,
|
|
|
|
const char *filename,
|
|
|
|
gdb::unique_xmalloc_ptr<char> *destname)
|
|
|
|
{
|
|
|
|
return scoped_fd (-ENOSYS);
|
|
|
|
}
|
|
|
|
|
2021-10-30 07:55:57 +08:00
|
|
|
#define NO_IMPL _("Support for debuginfod is not compiled into GDB.")
|
|
|
|
|
2020-02-27 06:40:49 +08:00
|
|
|
#else
|
|
|
|
#include <elfutils/debuginfod.h>
|
|
|
|
|
2020-08-14 05:47:05 +08:00
|
|
|
struct user_data
|
|
|
|
{
|
|
|
|
user_data (const char *desc, const char *fname)
|
2022-03-23 08:01:54 +08:00
|
|
|
: desc (desc), fname (fname), has_printed (false)
|
2020-08-14 05:47:05 +08:00
|
|
|
{ }
|
|
|
|
|
|
|
|
const char * const desc;
|
|
|
|
const char * const fname;
|
2022-03-23 08:01:54 +08:00
|
|
|
bool has_printed;
|
2020-08-14 05:47:05 +08:00
|
|
|
};
|
2020-02-27 06:40:49 +08:00
|
|
|
|
2020-09-15 10:28:42 +08:00
|
|
|
/* Deleter for a debuginfod_client. */
|
|
|
|
|
|
|
|
struct debuginfod_client_deleter
|
|
|
|
{
|
|
|
|
void operator() (debuginfod_client *c)
|
|
|
|
{
|
|
|
|
debuginfod_end (c);
|
|
|
|
}
|
|
|
|
};
|
|
|
|
|
|
|
|
using debuginfod_client_up
|
|
|
|
= std::unique_ptr<debuginfod_client, debuginfod_client_deleter>;
|
|
|
|
|
2020-02-27 06:40:49 +08:00
|
|
|
static int
|
|
|
|
progressfn (debuginfod_client *c, long cur, long total)
|
|
|
|
{
|
2020-08-14 05:47:05 +08:00
|
|
|
user_data *data = static_cast<user_data *> (debuginfod_get_user_data (c));
|
2021-05-07 23:37:16 +08:00
|
|
|
gdb_assert (data != nullptr);
|
2020-08-14 05:47:05 +08:00
|
|
|
|
2020-02-27 06:40:49 +08:00
|
|
|
if (check_quit_flag ())
|
|
|
|
{
|
2022-01-03 02:46:15 +08:00
|
|
|
gdb_printf ("Cancelling download of %s %ps...\n",
|
|
|
|
data->desc,
|
|
|
|
styled_string (file_name_style.style (), data->fname));
|
2020-02-27 06:40:49 +08:00
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
|
2022-03-23 08:01:54 +08:00
|
|
|
if (!data->has_printed)
|
2020-02-27 06:40:49 +08:00
|
|
|
{
|
2022-03-23 08:01:54 +08:00
|
|
|
/* Include the transfer size, if available. */
|
|
|
|
if (total > 0)
|
|
|
|
{
|
|
|
|
float size = 1.0f * total / 1024;
|
|
|
|
const char *unit = "KB";
|
|
|
|
|
|
|
|
/* If size is greater than 0.01 MB, set unit to MB. */
|
|
|
|
if (size > 10.24)
|
|
|
|
{
|
|
|
|
size /= 1024;
|
|
|
|
unit = "MB";
|
|
|
|
}
|
|
|
|
|
2022-01-03 02:46:15 +08:00
|
|
|
gdb_printf ("Downloading %.2f %s %s %ps...\n",
|
|
|
|
size, unit, data->desc,
|
|
|
|
styled_string (file_name_style.style (),
|
|
|
|
data->fname));
|
2022-03-23 08:01:54 +08:00
|
|
|
}
|
|
|
|
else
|
2022-01-03 02:46:15 +08:00
|
|
|
gdb_printf ("Downloading %s %ps...\n", data->desc,
|
|
|
|
styled_string (file_name_style.style (), data->fname));
|
2022-03-23 08:01:54 +08:00
|
|
|
|
|
|
|
data->has_printed = true;
|
2020-02-27 06:40:49 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2021-05-07 23:37:16 +08:00
|
|
|
static debuginfod_client *
|
|
|
|
get_debuginfod_client ()
|
2020-02-27 06:40:49 +08:00
|
|
|
{
|
2021-05-07 23:37:16 +08:00
|
|
|
static debuginfod_client_up global_client;
|
2020-02-27 06:40:49 +08:00
|
|
|
|
2021-05-07 23:37:16 +08:00
|
|
|
if (global_client == nullptr)
|
|
|
|
{
|
|
|
|
global_client.reset (debuginfod_begin ());
|
|
|
|
|
|
|
|
if (global_client != nullptr)
|
|
|
|
debuginfod_set_progressfn (global_client.get (), progressfn);
|
|
|
|
}
|
2020-02-27 06:40:49 +08:00
|
|
|
|
2021-05-07 23:37:16 +08:00
|
|
|
return global_client.get ();
|
2020-02-27 06:40:49 +08:00
|
|
|
}
|
|
|
|
|
2021-10-30 07:55:57 +08:00
|
|
|
/* Check if debuginfod is enabled. If configured to do so, ask the user
|
|
|
|
whether to enable debuginfod. */
|
|
|
|
|
|
|
|
static bool
|
gdb: rework "set debuginfod" commands
As discussed here [1], do some re-work in the "set debuginfod commands".
First, use "set debuginfod enabled on/off/ask" instead of "set
debuginfod on/off/ask". This is more MI-friendly, and it gives an
output that makes more sense in "info set", for example.
Then, make the show commands not call "error" when debuginfod support is
not compiled in. This makes the commands "show" and "show debuginfod"
stop early, breaking gdb.base/default.exp:
Running /home/smarchi/src/binutils-gdb/gdb/testsuite/gdb.base/default.exp ...
FAIL: gdb.base/default.exp: info set
FAIL: gdb.base/default.exp: show
- Make the "debuginfod enabled" setting default to "off" when debuginfod
support is not compiled in, and "ask" otherwise.
- Make the setter of "debuginfod enabled" error out when debuginfod
support is not compiled in, so that "debuginfod enabled" will always
remain "off" in that case.
- Make the setter of "debuginfod verbose" work in any case. I don't
see the harm in letting the user change that setting, since the user will
hit an error if they try to enable the use of debuginfod.
- I would do the same for the "debuginfod urls" setter, but because
this one needs to see the DEBUGINFOD_URLS_ENV_VAR macro, provided by
libdebuginfod, I made that one error out as well if debuginfod
support is not compiled it (otherwise, I would have left it like
"debuginfod verbose". Alternatively, we could hard-code
"DEBUGINFOD_URLS" in the code (in fact, it was prior to this patch,
but I think it was an oversight, as other spots use
DEBUGINFOD_URLS_ENV_VAR), or use a dummy string to store the setting,
but I don't really see the value in that.
Rename debuginfod_enable to debuginfod_enabled, just so it matches the
setting name.
[1] https://sourceware.org/pipermail/gdb-patches/2021-October/182937.html
Change-Id: I45fdb2993f668226a5639228951362b7800f09d5
Co-Authored-By: Aaron Merey <amerey@redhat.com>
2021-11-03 00:21:31 +08:00
|
|
|
debuginfod_is_enabled ()
|
2021-10-30 07:55:57 +08:00
|
|
|
{
|
2022-04-28 04:41:24 +08:00
|
|
|
const char *urls = skip_spaces (getenv (DEBUGINFOD_URLS_ENV_VAR));
|
2021-10-30 07:55:57 +08:00
|
|
|
|
2022-04-28 04:41:24 +08:00
|
|
|
if (debuginfod_enabled == debuginfod_off
|
|
|
|
|| urls == nullptr
|
|
|
|
|| *urls == '\0')
|
2021-10-30 07:55:57 +08:00
|
|
|
return false;
|
|
|
|
|
gdb: rework "set debuginfod" commands
As discussed here [1], do some re-work in the "set debuginfod commands".
First, use "set debuginfod enabled on/off/ask" instead of "set
debuginfod on/off/ask". This is more MI-friendly, and it gives an
output that makes more sense in "info set", for example.
Then, make the show commands not call "error" when debuginfod support is
not compiled in. This makes the commands "show" and "show debuginfod"
stop early, breaking gdb.base/default.exp:
Running /home/smarchi/src/binutils-gdb/gdb/testsuite/gdb.base/default.exp ...
FAIL: gdb.base/default.exp: info set
FAIL: gdb.base/default.exp: show
- Make the "debuginfod enabled" setting default to "off" when debuginfod
support is not compiled in, and "ask" otherwise.
- Make the setter of "debuginfod enabled" error out when debuginfod
support is not compiled in, so that "debuginfod enabled" will always
remain "off" in that case.
- Make the setter of "debuginfod verbose" work in any case. I don't
see the harm in letting the user change that setting, since the user will
hit an error if they try to enable the use of debuginfod.
- I would do the same for the "debuginfod urls" setter, but because
this one needs to see the DEBUGINFOD_URLS_ENV_VAR macro, provided by
libdebuginfod, I made that one error out as well if debuginfod
support is not compiled it (otherwise, I would have left it like
"debuginfod verbose". Alternatively, we could hard-code
"DEBUGINFOD_URLS" in the code (in fact, it was prior to this patch,
but I think it was an oversight, as other spots use
DEBUGINFOD_URLS_ENV_VAR), or use a dummy string to store the setting,
but I don't really see the value in that.
Rename debuginfod_enable to debuginfod_enabled, just so it matches the
setting name.
[1] https://sourceware.org/pipermail/gdb-patches/2021-October/182937.html
Change-Id: I45fdb2993f668226a5639228951362b7800f09d5
Co-Authored-By: Aaron Merey <amerey@redhat.com>
2021-11-03 00:21:31 +08:00
|
|
|
if (debuginfod_enabled == debuginfod_ask)
|
2021-10-30 07:55:57 +08:00
|
|
|
{
|
2022-03-10 08:26:37 +08:00
|
|
|
gdb_printf (_("\nThis GDB supports auto-downloading debuginfo " \
|
|
|
|
"from the following URLs:\n"));
|
|
|
|
|
|
|
|
gdb::string_view url_view (urls);
|
|
|
|
while (true)
|
|
|
|
{
|
2022-04-09 06:50:56 +08:00
|
|
|
size_t off = url_view.find_first_not_of (' ');
|
|
|
|
if (off == gdb::string_view::npos)
|
2022-03-10 08:26:37 +08:00
|
|
|
break;
|
2022-04-09 06:50:56 +08:00
|
|
|
url_view = url_view.substr (off);
|
2022-05-31 17:00:06 +08:00
|
|
|
/* g++ 11.2.1 on s390x, g++ 11.3.1 on ppc64le and g++ 11 on
|
|
|
|
hppa seem convinced url_view might be of SIZE_MAX length.
|
|
|
|
And so complains because the length of an array can only
|
|
|
|
be PTRDIFF_MAX. */
|
2022-05-04 07:17:31 +08:00
|
|
|
DIAGNOSTIC_PUSH
|
|
|
|
DIAGNOSTIC_IGNORE_STRINGOP_OVERREAD
|
2022-04-09 06:50:56 +08:00
|
|
|
off = url_view.find_first_of (' ');
|
2022-05-04 07:17:31 +08:00
|
|
|
DIAGNOSTIC_POP
|
2022-03-10 08:26:37 +08:00
|
|
|
gdb_printf
|
|
|
|
(_(" <%ps>\n"),
|
|
|
|
styled_string (file_name_style.style (),
|
|
|
|
gdb::to_string (url_view.substr (0,
|
|
|
|
off)).c_str ()));
|
|
|
|
if (off == gdb::string_view::npos)
|
|
|
|
break;
|
|
|
|
url_view = url_view.substr (off);
|
|
|
|
}
|
|
|
|
|
|
|
|
int resp = nquery (_("Enable debuginfod for this session? "));
|
2021-10-30 07:55:57 +08:00
|
|
|
if (!resp)
|
|
|
|
{
|
2022-01-03 02:46:15 +08:00
|
|
|
gdb_printf (_("Debuginfod has been disabled.\nTo make this " \
|
|
|
|
"setting permanent, add \'set debuginfod " \
|
|
|
|
"enabled off\' to .gdbinit.\n"));
|
gdb: rework "set debuginfod" commands
As discussed here [1], do some re-work in the "set debuginfod commands".
First, use "set debuginfod enabled on/off/ask" instead of "set
debuginfod on/off/ask". This is more MI-friendly, and it gives an
output that makes more sense in "info set", for example.
Then, make the show commands not call "error" when debuginfod support is
not compiled in. This makes the commands "show" and "show debuginfod"
stop early, breaking gdb.base/default.exp:
Running /home/smarchi/src/binutils-gdb/gdb/testsuite/gdb.base/default.exp ...
FAIL: gdb.base/default.exp: info set
FAIL: gdb.base/default.exp: show
- Make the "debuginfod enabled" setting default to "off" when debuginfod
support is not compiled in, and "ask" otherwise.
- Make the setter of "debuginfod enabled" error out when debuginfod
support is not compiled in, so that "debuginfod enabled" will always
remain "off" in that case.
- Make the setter of "debuginfod verbose" work in any case. I don't
see the harm in letting the user change that setting, since the user will
hit an error if they try to enable the use of debuginfod.
- I would do the same for the "debuginfod urls" setter, but because
this one needs to see the DEBUGINFOD_URLS_ENV_VAR macro, provided by
libdebuginfod, I made that one error out as well if debuginfod
support is not compiled it (otherwise, I would have left it like
"debuginfod verbose". Alternatively, we could hard-code
"DEBUGINFOD_URLS" in the code (in fact, it was prior to this patch,
but I think it was an oversight, as other spots use
DEBUGINFOD_URLS_ENV_VAR), or use a dummy string to store the setting,
but I don't really see the value in that.
Rename debuginfod_enable to debuginfod_enabled, just so it matches the
setting name.
[1] https://sourceware.org/pipermail/gdb-patches/2021-October/182937.html
Change-Id: I45fdb2993f668226a5639228951362b7800f09d5
Co-Authored-By: Aaron Merey <amerey@redhat.com>
2021-11-03 00:21:31 +08:00
|
|
|
debuginfod_enabled = debuginfod_off;
|
2021-10-30 07:55:57 +08:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2022-01-03 02:46:15 +08:00
|
|
|
gdb_printf (_("Debuginfod has been enabled.\nTo make this " \
|
|
|
|
"setting permanent, add \'set debuginfod enabled " \
|
|
|
|
"on\' to .gdbinit.\n"));
|
gdb: rework "set debuginfod" commands
As discussed here [1], do some re-work in the "set debuginfod commands".
First, use "set debuginfod enabled on/off/ask" instead of "set
debuginfod on/off/ask". This is more MI-friendly, and it gives an
output that makes more sense in "info set", for example.
Then, make the show commands not call "error" when debuginfod support is
not compiled in. This makes the commands "show" and "show debuginfod"
stop early, breaking gdb.base/default.exp:
Running /home/smarchi/src/binutils-gdb/gdb/testsuite/gdb.base/default.exp ...
FAIL: gdb.base/default.exp: info set
FAIL: gdb.base/default.exp: show
- Make the "debuginfod enabled" setting default to "off" when debuginfod
support is not compiled in, and "ask" otherwise.
- Make the setter of "debuginfod enabled" error out when debuginfod
support is not compiled in, so that "debuginfod enabled" will always
remain "off" in that case.
- Make the setter of "debuginfod verbose" work in any case. I don't
see the harm in letting the user change that setting, since the user will
hit an error if they try to enable the use of debuginfod.
- I would do the same for the "debuginfod urls" setter, but because
this one needs to see the DEBUGINFOD_URLS_ENV_VAR macro, provided by
libdebuginfod, I made that one error out as well if debuginfod
support is not compiled it (otherwise, I would have left it like
"debuginfod verbose". Alternatively, we could hard-code
"DEBUGINFOD_URLS" in the code (in fact, it was prior to this patch,
but I think it was an oversight, as other spots use
DEBUGINFOD_URLS_ENV_VAR), or use a dummy string to store the setting,
but I don't really see the value in that.
Rename debuginfod_enable to debuginfod_enabled, just so it matches the
setting name.
[1] https://sourceware.org/pipermail/gdb-patches/2021-October/182937.html
Change-Id: I45fdb2993f668226a5639228951362b7800f09d5
Co-Authored-By: Aaron Merey <amerey@redhat.com>
2021-11-03 00:21:31 +08:00
|
|
|
debuginfod_enabled = debuginfod_on;
|
2021-10-30 07:55:57 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2020-02-27 06:40:49 +08:00
|
|
|
/* See debuginfod-support.h */
|
|
|
|
|
|
|
|
scoped_fd
|
|
|
|
debuginfod_source_query (const unsigned char *build_id,
|
|
|
|
int build_id_len,
|
|
|
|
const char *srcpath,
|
|
|
|
gdb::unique_xmalloc_ptr<char> *destname)
|
|
|
|
{
|
gdb: rework "set debuginfod" commands
As discussed here [1], do some re-work in the "set debuginfod commands".
First, use "set debuginfod enabled on/off/ask" instead of "set
debuginfod on/off/ask". This is more MI-friendly, and it gives an
output that makes more sense in "info set", for example.
Then, make the show commands not call "error" when debuginfod support is
not compiled in. This makes the commands "show" and "show debuginfod"
stop early, breaking gdb.base/default.exp:
Running /home/smarchi/src/binutils-gdb/gdb/testsuite/gdb.base/default.exp ...
FAIL: gdb.base/default.exp: info set
FAIL: gdb.base/default.exp: show
- Make the "debuginfod enabled" setting default to "off" when debuginfod
support is not compiled in, and "ask" otherwise.
- Make the setter of "debuginfod enabled" error out when debuginfod
support is not compiled in, so that "debuginfod enabled" will always
remain "off" in that case.
- Make the setter of "debuginfod verbose" work in any case. I don't
see the harm in letting the user change that setting, since the user will
hit an error if they try to enable the use of debuginfod.
- I would do the same for the "debuginfod urls" setter, but because
this one needs to see the DEBUGINFOD_URLS_ENV_VAR macro, provided by
libdebuginfod, I made that one error out as well if debuginfod
support is not compiled it (otherwise, I would have left it like
"debuginfod verbose". Alternatively, we could hard-code
"DEBUGINFOD_URLS" in the code (in fact, it was prior to this patch,
but I think it was an oversight, as other spots use
DEBUGINFOD_URLS_ENV_VAR), or use a dummy string to store the setting,
but I don't really see the value in that.
Rename debuginfod_enable to debuginfod_enabled, just so it matches the
setting name.
[1] https://sourceware.org/pipermail/gdb-patches/2021-October/182937.html
Change-Id: I45fdb2993f668226a5639228951362b7800f09d5
Co-Authored-By: Aaron Merey <amerey@redhat.com>
2021-11-03 00:21:31 +08:00
|
|
|
if (!debuginfod_is_enabled ())
|
2020-02-27 06:40:49 +08:00
|
|
|
return scoped_fd (-ENOSYS);
|
|
|
|
|
2021-05-07 23:37:16 +08:00
|
|
|
debuginfod_client *c = get_debuginfod_client ();
|
2020-02-27 06:40:49 +08:00
|
|
|
|
|
|
|
if (c == nullptr)
|
|
|
|
return scoped_fd (-ENOMEM);
|
|
|
|
|
2021-11-20 08:41:40 +08:00
|
|
|
char *dname = nullptr;
|
2020-08-14 05:47:05 +08:00
|
|
|
user_data data ("source file", srcpath);
|
2020-02-27 06:40:49 +08:00
|
|
|
|
2021-05-07 23:37:16 +08:00
|
|
|
debuginfod_set_user_data (c, &data);
|
2021-11-30 03:58:38 +08:00
|
|
|
gdb::optional<target_terminal::scoped_restore_terminal_state> term_state;
|
|
|
|
if (target_supports_terminal_ours ())
|
|
|
|
{
|
|
|
|
term_state.emplace ();
|
|
|
|
target_terminal::ours ();
|
|
|
|
}
|
|
|
|
|
2021-05-07 23:37:16 +08:00
|
|
|
scoped_fd fd (debuginfod_find_source (c,
|
2020-02-27 06:40:49 +08:00
|
|
|
build_id,
|
|
|
|
build_id_len,
|
|
|
|
srcpath,
|
2021-11-20 08:41:40 +08:00
|
|
|
&dname));
|
2021-05-07 23:37:16 +08:00
|
|
|
debuginfod_set_user_data (c, nullptr);
|
2020-02-27 06:40:49 +08:00
|
|
|
|
2022-04-02 04:39:18 +08:00
|
|
|
if (fd.get () < 0 && fd.get () != -ENOENT)
|
2022-01-03 02:46:15 +08:00
|
|
|
gdb_printf (_("Download failed: %s. Continuing without source file %ps.\n"),
|
|
|
|
safe_strerror (-fd.get ()),
|
|
|
|
styled_string (file_name_style.style (), srcpath));
|
2020-11-24 03:09:50 +08:00
|
|
|
|
|
|
|
if (fd.get () >= 0)
|
2021-11-20 08:41:40 +08:00
|
|
|
destname->reset (dname);
|
2020-02-27 06:40:49 +08:00
|
|
|
|
|
|
|
return fd;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* See debuginfod-support.h */
|
|
|
|
|
|
|
|
scoped_fd
|
|
|
|
debuginfod_debuginfo_query (const unsigned char *build_id,
|
|
|
|
int build_id_len,
|
|
|
|
const char *filename,
|
|
|
|
gdb::unique_xmalloc_ptr<char> *destname)
|
|
|
|
{
|
gdb: rework "set debuginfod" commands
As discussed here [1], do some re-work in the "set debuginfod commands".
First, use "set debuginfod enabled on/off/ask" instead of "set
debuginfod on/off/ask". This is more MI-friendly, and it gives an
output that makes more sense in "info set", for example.
Then, make the show commands not call "error" when debuginfod support is
not compiled in. This makes the commands "show" and "show debuginfod"
stop early, breaking gdb.base/default.exp:
Running /home/smarchi/src/binutils-gdb/gdb/testsuite/gdb.base/default.exp ...
FAIL: gdb.base/default.exp: info set
FAIL: gdb.base/default.exp: show
- Make the "debuginfod enabled" setting default to "off" when debuginfod
support is not compiled in, and "ask" otherwise.
- Make the setter of "debuginfod enabled" error out when debuginfod
support is not compiled in, so that "debuginfod enabled" will always
remain "off" in that case.
- Make the setter of "debuginfod verbose" work in any case. I don't
see the harm in letting the user change that setting, since the user will
hit an error if they try to enable the use of debuginfod.
- I would do the same for the "debuginfod urls" setter, but because
this one needs to see the DEBUGINFOD_URLS_ENV_VAR macro, provided by
libdebuginfod, I made that one error out as well if debuginfod
support is not compiled it (otherwise, I would have left it like
"debuginfod verbose". Alternatively, we could hard-code
"DEBUGINFOD_URLS" in the code (in fact, it was prior to this patch,
but I think it was an oversight, as other spots use
DEBUGINFOD_URLS_ENV_VAR), or use a dummy string to store the setting,
but I don't really see the value in that.
Rename debuginfod_enable to debuginfod_enabled, just so it matches the
setting name.
[1] https://sourceware.org/pipermail/gdb-patches/2021-October/182937.html
Change-Id: I45fdb2993f668226a5639228951362b7800f09d5
Co-Authored-By: Aaron Merey <amerey@redhat.com>
2021-11-03 00:21:31 +08:00
|
|
|
if (!debuginfod_is_enabled ())
|
2020-02-27 06:40:49 +08:00
|
|
|
return scoped_fd (-ENOSYS);
|
|
|
|
|
2021-05-07 23:37:16 +08:00
|
|
|
debuginfod_client *c = get_debuginfod_client ();
|
2020-02-27 06:40:49 +08:00
|
|
|
|
|
|
|
if (c == nullptr)
|
|
|
|
return scoped_fd (-ENOMEM);
|
|
|
|
|
|
|
|
char *dname = nullptr;
|
2020-08-14 05:47:05 +08:00
|
|
|
user_data data ("separate debug info for", filename);
|
2020-02-27 06:40:49 +08:00
|
|
|
|
2021-05-07 23:37:16 +08:00
|
|
|
debuginfod_set_user_data (c, &data);
|
2021-11-30 03:58:38 +08:00
|
|
|
gdb::optional<target_terminal::scoped_restore_terminal_state> term_state;
|
|
|
|
if (target_supports_terminal_ours ())
|
|
|
|
{
|
|
|
|
term_state.emplace ();
|
|
|
|
target_terminal::ours ();
|
|
|
|
}
|
|
|
|
|
2021-05-07 23:37:16 +08:00
|
|
|
scoped_fd fd (debuginfod_find_debuginfo (c, build_id, build_id_len,
|
2020-09-15 10:28:42 +08:00
|
|
|
&dname));
|
2021-05-07 23:37:16 +08:00
|
|
|
debuginfod_set_user_data (c, nullptr);
|
2020-02-27 06:40:49 +08:00
|
|
|
|
2022-04-02 04:39:18 +08:00
|
|
|
if (fd.get () < 0 && fd.get () != -ENOENT)
|
2022-01-03 02:46:15 +08:00
|
|
|
gdb_printf (_("Download failed: %s. Continuing without debug info for %ps.\n"),
|
|
|
|
safe_strerror (-fd.get ()),
|
|
|
|
styled_string (file_name_style.style (), filename));
|
2020-02-27 06:40:49 +08:00
|
|
|
|
2020-11-24 03:09:50 +08:00
|
|
|
if (fd.get () >= 0)
|
|
|
|
destname->reset (dname);
|
2020-09-15 10:28:42 +08:00
|
|
|
|
2020-02-27 06:40:49 +08:00
|
|
|
return fd;
|
|
|
|
}
|
2022-03-03 09:00:59 +08:00
|
|
|
|
|
|
|
/* See debuginfod-support.h */
|
|
|
|
|
|
|
|
scoped_fd
|
|
|
|
debuginfod_exec_query (const unsigned char *build_id,
|
|
|
|
int build_id_len,
|
|
|
|
const char *filename,
|
|
|
|
gdb::unique_xmalloc_ptr<char> *destname)
|
|
|
|
{
|
|
|
|
if (!debuginfod_is_enabled ())
|
|
|
|
return scoped_fd (-ENOSYS);
|
|
|
|
|
|
|
|
debuginfod_client *c = get_debuginfod_client ();
|
|
|
|
|
|
|
|
if (c == nullptr)
|
|
|
|
return scoped_fd (-ENOMEM);
|
|
|
|
|
|
|
|
char *dname = nullptr;
|
|
|
|
user_data data ("executable for", filename);
|
|
|
|
|
|
|
|
debuginfod_set_user_data (c, &data);
|
|
|
|
gdb::optional<target_terminal::scoped_restore_terminal_state> term_state;
|
|
|
|
if (target_supports_terminal_ours ())
|
|
|
|
{
|
|
|
|
term_state.emplace ();
|
|
|
|
target_terminal::ours ();
|
|
|
|
}
|
|
|
|
|
|
|
|
scoped_fd fd (debuginfod_find_executable (c, build_id, build_id_len, &dname));
|
|
|
|
debuginfod_set_user_data (c, nullptr);
|
|
|
|
|
2022-04-02 04:39:18 +08:00
|
|
|
if (fd.get () < 0 && fd.get () != -ENOENT)
|
2022-01-03 02:46:15 +08:00
|
|
|
gdb_printf (_("Download failed: %s. " \
|
|
|
|
"Continuing without executable for %ps.\n"),
|
|
|
|
safe_strerror (-fd.get ()),
|
|
|
|
styled_string (file_name_style.style (), filename));
|
2022-03-03 09:00:59 +08:00
|
|
|
|
|
|
|
if (fd.get () >= 0)
|
|
|
|
destname->reset (dname);
|
|
|
|
|
|
|
|
return fd;
|
|
|
|
}
|
2020-02-27 06:40:49 +08:00
|
|
|
#endif
|
2021-10-30 07:55:57 +08:00
|
|
|
|
gdb: rework "set debuginfod" commands
As discussed here [1], do some re-work in the "set debuginfod commands".
First, use "set debuginfod enabled on/off/ask" instead of "set
debuginfod on/off/ask". This is more MI-friendly, and it gives an
output that makes more sense in "info set", for example.
Then, make the show commands not call "error" when debuginfod support is
not compiled in. This makes the commands "show" and "show debuginfod"
stop early, breaking gdb.base/default.exp:
Running /home/smarchi/src/binutils-gdb/gdb/testsuite/gdb.base/default.exp ...
FAIL: gdb.base/default.exp: info set
FAIL: gdb.base/default.exp: show
- Make the "debuginfod enabled" setting default to "off" when debuginfod
support is not compiled in, and "ask" otherwise.
- Make the setter of "debuginfod enabled" error out when debuginfod
support is not compiled in, so that "debuginfod enabled" will always
remain "off" in that case.
- Make the setter of "debuginfod verbose" work in any case. I don't
see the harm in letting the user change that setting, since the user will
hit an error if they try to enable the use of debuginfod.
- I would do the same for the "debuginfod urls" setter, but because
this one needs to see the DEBUGINFOD_URLS_ENV_VAR macro, provided by
libdebuginfod, I made that one error out as well if debuginfod
support is not compiled it (otherwise, I would have left it like
"debuginfod verbose". Alternatively, we could hard-code
"DEBUGINFOD_URLS" in the code (in fact, it was prior to this patch,
but I think it was an oversight, as other spots use
DEBUGINFOD_URLS_ENV_VAR), or use a dummy string to store the setting,
but I don't really see the value in that.
Rename debuginfod_enable to debuginfod_enabled, just so it matches the
setting name.
[1] https://sourceware.org/pipermail/gdb-patches/2021-October/182937.html
Change-Id: I45fdb2993f668226a5639228951362b7800f09d5
Co-Authored-By: Aaron Merey <amerey@redhat.com>
2021-11-03 00:21:31 +08:00
|
|
|
/* Set callback for "set debuginfod enabled". */
|
|
|
|
|
|
|
|
static void
|
|
|
|
set_debuginfod_enabled (const char *value)
|
|
|
|
{
|
|
|
|
#if defined(HAVE_LIBDEBUGINFOD)
|
|
|
|
debuginfod_enabled = value;
|
|
|
|
#else
|
2022-07-06 06:11:49 +08:00
|
|
|
/* Disabling debuginfod when gdb is not built with it is a no-op. */
|
|
|
|
if (value != debuginfod_off)
|
|
|
|
error (NO_IMPL);
|
gdb: rework "set debuginfod" commands
As discussed here [1], do some re-work in the "set debuginfod commands".
First, use "set debuginfod enabled on/off/ask" instead of "set
debuginfod on/off/ask". This is more MI-friendly, and it gives an
output that makes more sense in "info set", for example.
Then, make the show commands not call "error" when debuginfod support is
not compiled in. This makes the commands "show" and "show debuginfod"
stop early, breaking gdb.base/default.exp:
Running /home/smarchi/src/binutils-gdb/gdb/testsuite/gdb.base/default.exp ...
FAIL: gdb.base/default.exp: info set
FAIL: gdb.base/default.exp: show
- Make the "debuginfod enabled" setting default to "off" when debuginfod
support is not compiled in, and "ask" otherwise.
- Make the setter of "debuginfod enabled" error out when debuginfod
support is not compiled in, so that "debuginfod enabled" will always
remain "off" in that case.
- Make the setter of "debuginfod verbose" work in any case. I don't
see the harm in letting the user change that setting, since the user will
hit an error if they try to enable the use of debuginfod.
- I would do the same for the "debuginfod urls" setter, but because
this one needs to see the DEBUGINFOD_URLS_ENV_VAR macro, provided by
libdebuginfod, I made that one error out as well if debuginfod
support is not compiled it (otherwise, I would have left it like
"debuginfod verbose". Alternatively, we could hard-code
"DEBUGINFOD_URLS" in the code (in fact, it was prior to this patch,
but I think it was an oversight, as other spots use
DEBUGINFOD_URLS_ENV_VAR), or use a dummy string to store the setting,
but I don't really see the value in that.
Rename debuginfod_enable to debuginfod_enabled, just so it matches the
setting name.
[1] https://sourceware.org/pipermail/gdb-patches/2021-October/182937.html
Change-Id: I45fdb2993f668226a5639228951362b7800f09d5
Co-Authored-By: Aaron Merey <amerey@redhat.com>
2021-11-03 00:21:31 +08:00
|
|
|
#endif
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Get callback for "set debuginfod enabled". */
|
|
|
|
|
|
|
|
static const char *
|
|
|
|
get_debuginfod_enabled ()
|
|
|
|
{
|
|
|
|
return debuginfod_enabled;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Show callback for "set debuginfod enabled". */
|
|
|
|
|
|
|
|
static void
|
|
|
|
show_debuginfod_enabled (ui_file *file, int from_tty, cmd_list_element *cmd,
|
|
|
|
const char *value)
|
|
|
|
{
|
2022-01-03 02:46:15 +08:00
|
|
|
gdb_printf (file,
|
|
|
|
_("Debuginfod functionality is currently set to "
|
|
|
|
"\"%s\".\n"), debuginfod_enabled);
|
gdb: rework "set debuginfod" commands
As discussed here [1], do some re-work in the "set debuginfod commands".
First, use "set debuginfod enabled on/off/ask" instead of "set
debuginfod on/off/ask". This is more MI-friendly, and it gives an
output that makes more sense in "info set", for example.
Then, make the show commands not call "error" when debuginfod support is
not compiled in. This makes the commands "show" and "show debuginfod"
stop early, breaking gdb.base/default.exp:
Running /home/smarchi/src/binutils-gdb/gdb/testsuite/gdb.base/default.exp ...
FAIL: gdb.base/default.exp: info set
FAIL: gdb.base/default.exp: show
- Make the "debuginfod enabled" setting default to "off" when debuginfod
support is not compiled in, and "ask" otherwise.
- Make the setter of "debuginfod enabled" error out when debuginfod
support is not compiled in, so that "debuginfod enabled" will always
remain "off" in that case.
- Make the setter of "debuginfod verbose" work in any case. I don't
see the harm in letting the user change that setting, since the user will
hit an error if they try to enable the use of debuginfod.
- I would do the same for the "debuginfod urls" setter, but because
this one needs to see the DEBUGINFOD_URLS_ENV_VAR macro, provided by
libdebuginfod, I made that one error out as well if debuginfod
support is not compiled it (otherwise, I would have left it like
"debuginfod verbose". Alternatively, we could hard-code
"DEBUGINFOD_URLS" in the code (in fact, it was prior to this patch,
but I think it was an oversight, as other spots use
DEBUGINFOD_URLS_ENV_VAR), or use a dummy string to store the setting,
but I don't really see the value in that.
Rename debuginfod_enable to debuginfod_enabled, just so it matches the
setting name.
[1] https://sourceware.org/pipermail/gdb-patches/2021-October/182937.html
Change-Id: I45fdb2993f668226a5639228951362b7800f09d5
Co-Authored-By: Aaron Merey <amerey@redhat.com>
2021-11-03 00:21:31 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/* Set callback for "set debuginfod urls". */
|
|
|
|
|
|
|
|
static void
|
|
|
|
set_debuginfod_urls (const std::string &urls)
|
|
|
|
{
|
|
|
|
#if defined(HAVE_LIBDEBUGINFOD)
|
|
|
|
if (setenv (DEBUGINFOD_URLS_ENV_VAR, urls.c_str (), 1) != 0)
|
|
|
|
warning (_("Unable to set debuginfod URLs: %s"), safe_strerror (errno));
|
|
|
|
#else
|
|
|
|
error (NO_IMPL);
|
|
|
|
#endif
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Get callback for "set debuginfod urls". */
|
|
|
|
|
|
|
|
static const std::string&
|
|
|
|
get_debuginfod_urls ()
|
|
|
|
{
|
|
|
|
static std::string urls;
|
|
|
|
#if defined(HAVE_LIBDEBUGINFOD)
|
|
|
|
const char *envvar = getenv (DEBUGINFOD_URLS_ENV_VAR);
|
|
|
|
|
|
|
|
if (envvar != nullptr)
|
|
|
|
urls = envvar;
|
|
|
|
else
|
|
|
|
urls.clear ();
|
|
|
|
#endif
|
|
|
|
|
|
|
|
return urls;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Show callback for "set debuginfod urls". */
|
|
|
|
|
|
|
|
static void
|
|
|
|
show_debuginfod_urls (ui_file *file, int from_tty, cmd_list_element *cmd,
|
|
|
|
const char *value)
|
|
|
|
{
|
|
|
|
if (value[0] == '\0')
|
2022-01-03 02:46:15 +08:00
|
|
|
gdb_printf (file, _("Debuginfod URLs have not been set.\n"));
|
gdb: rework "set debuginfod" commands
As discussed here [1], do some re-work in the "set debuginfod commands".
First, use "set debuginfod enabled on/off/ask" instead of "set
debuginfod on/off/ask". This is more MI-friendly, and it gives an
output that makes more sense in "info set", for example.
Then, make the show commands not call "error" when debuginfod support is
not compiled in. This makes the commands "show" and "show debuginfod"
stop early, breaking gdb.base/default.exp:
Running /home/smarchi/src/binutils-gdb/gdb/testsuite/gdb.base/default.exp ...
FAIL: gdb.base/default.exp: info set
FAIL: gdb.base/default.exp: show
- Make the "debuginfod enabled" setting default to "off" when debuginfod
support is not compiled in, and "ask" otherwise.
- Make the setter of "debuginfod enabled" error out when debuginfod
support is not compiled in, so that "debuginfod enabled" will always
remain "off" in that case.
- Make the setter of "debuginfod verbose" work in any case. I don't
see the harm in letting the user change that setting, since the user will
hit an error if they try to enable the use of debuginfod.
- I would do the same for the "debuginfod urls" setter, but because
this one needs to see the DEBUGINFOD_URLS_ENV_VAR macro, provided by
libdebuginfod, I made that one error out as well if debuginfod
support is not compiled it (otherwise, I would have left it like
"debuginfod verbose". Alternatively, we could hard-code
"DEBUGINFOD_URLS" in the code (in fact, it was prior to this patch,
but I think it was an oversight, as other spots use
DEBUGINFOD_URLS_ENV_VAR), or use a dummy string to store the setting,
but I don't really see the value in that.
Rename debuginfod_enable to debuginfod_enabled, just so it matches the
setting name.
[1] https://sourceware.org/pipermail/gdb-patches/2021-October/182937.html
Change-Id: I45fdb2993f668226a5639228951362b7800f09d5
Co-Authored-By: Aaron Merey <amerey@redhat.com>
2021-11-03 00:21:31 +08:00
|
|
|
else
|
2022-01-03 02:46:15 +08:00
|
|
|
gdb_printf (file, _("Debuginfod URLs are currently set to:\n%s\n"),
|
|
|
|
value);
|
gdb: rework "set debuginfod" commands
As discussed here [1], do some re-work in the "set debuginfod commands".
First, use "set debuginfod enabled on/off/ask" instead of "set
debuginfod on/off/ask". This is more MI-friendly, and it gives an
output that makes more sense in "info set", for example.
Then, make the show commands not call "error" when debuginfod support is
not compiled in. This makes the commands "show" and "show debuginfod"
stop early, breaking gdb.base/default.exp:
Running /home/smarchi/src/binutils-gdb/gdb/testsuite/gdb.base/default.exp ...
FAIL: gdb.base/default.exp: info set
FAIL: gdb.base/default.exp: show
- Make the "debuginfod enabled" setting default to "off" when debuginfod
support is not compiled in, and "ask" otherwise.
- Make the setter of "debuginfod enabled" error out when debuginfod
support is not compiled in, so that "debuginfod enabled" will always
remain "off" in that case.
- Make the setter of "debuginfod verbose" work in any case. I don't
see the harm in letting the user change that setting, since the user will
hit an error if they try to enable the use of debuginfod.
- I would do the same for the "debuginfod urls" setter, but because
this one needs to see the DEBUGINFOD_URLS_ENV_VAR macro, provided by
libdebuginfod, I made that one error out as well if debuginfod
support is not compiled it (otherwise, I would have left it like
"debuginfod verbose". Alternatively, we could hard-code
"DEBUGINFOD_URLS" in the code (in fact, it was prior to this patch,
but I think it was an oversight, as other spots use
DEBUGINFOD_URLS_ENV_VAR), or use a dummy string to store the setting,
but I don't really see the value in that.
Rename debuginfod_enable to debuginfod_enabled, just so it matches the
setting name.
[1] https://sourceware.org/pipermail/gdb-patches/2021-October/182937.html
Change-Id: I45fdb2993f668226a5639228951362b7800f09d5
Co-Authored-By: Aaron Merey <amerey@redhat.com>
2021-11-03 00:21:31 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/* Show callback for "set debuginfod verbose". */
|
|
|
|
|
|
|
|
static void
|
|
|
|
show_debuginfod_verbose_command (ui_file *file, int from_tty,
|
|
|
|
cmd_list_element *cmd, const char *value)
|
|
|
|
{
|
2022-01-03 02:46:15 +08:00
|
|
|
gdb_printf (file, _("Debuginfod verbose output is set to %s.\n"),
|
|
|
|
value);
|
gdb: rework "set debuginfod" commands
As discussed here [1], do some re-work in the "set debuginfod commands".
First, use "set debuginfod enabled on/off/ask" instead of "set
debuginfod on/off/ask". This is more MI-friendly, and it gives an
output that makes more sense in "info set", for example.
Then, make the show commands not call "error" when debuginfod support is
not compiled in. This makes the commands "show" and "show debuginfod"
stop early, breaking gdb.base/default.exp:
Running /home/smarchi/src/binutils-gdb/gdb/testsuite/gdb.base/default.exp ...
FAIL: gdb.base/default.exp: info set
FAIL: gdb.base/default.exp: show
- Make the "debuginfod enabled" setting default to "off" when debuginfod
support is not compiled in, and "ask" otherwise.
- Make the setter of "debuginfod enabled" error out when debuginfod
support is not compiled in, so that "debuginfod enabled" will always
remain "off" in that case.
- Make the setter of "debuginfod verbose" work in any case. I don't
see the harm in letting the user change that setting, since the user will
hit an error if they try to enable the use of debuginfod.
- I would do the same for the "debuginfod urls" setter, but because
this one needs to see the DEBUGINFOD_URLS_ENV_VAR macro, provided by
libdebuginfod, I made that one error out as well if debuginfod
support is not compiled it (otherwise, I would have left it like
"debuginfod verbose". Alternatively, we could hard-code
"DEBUGINFOD_URLS" in the code (in fact, it was prior to this patch,
but I think it was an oversight, as other spots use
DEBUGINFOD_URLS_ENV_VAR), or use a dummy string to store the setting,
but I don't really see the value in that.
Rename debuginfod_enable to debuginfod_enabled, just so it matches the
setting name.
[1] https://sourceware.org/pipermail/gdb-patches/2021-October/182937.html
Change-Id: I45fdb2993f668226a5639228951362b7800f09d5
Co-Authored-By: Aaron Merey <amerey@redhat.com>
2021-11-03 00:21:31 +08:00
|
|
|
}
|
|
|
|
|
2021-10-30 07:55:57 +08:00
|
|
|
/* Register debuginfod commands. */
|
|
|
|
|
|
|
|
void _initialize_debuginfod ();
|
|
|
|
void
|
|
|
|
_initialize_debuginfod ()
|
|
|
|
{
|
|
|
|
/* set/show debuginfod */
|
|
|
|
add_setshow_prefix_cmd ("debuginfod", class_run,
|
2021-11-01 01:34:06 +08:00
|
|
|
_("Set debuginfod options."),
|
|
|
|
_("Show debuginfod options."),
|
2021-10-30 07:55:57 +08:00
|
|
|
&set_debuginfod_prefix_list,
|
|
|
|
&show_debuginfod_prefix_list,
|
|
|
|
&setlist, &showlist);
|
|
|
|
|
gdb: rework "set debuginfod" commands
As discussed here [1], do some re-work in the "set debuginfod commands".
First, use "set debuginfod enabled on/off/ask" instead of "set
debuginfod on/off/ask". This is more MI-friendly, and it gives an
output that makes more sense in "info set", for example.
Then, make the show commands not call "error" when debuginfod support is
not compiled in. This makes the commands "show" and "show debuginfod"
stop early, breaking gdb.base/default.exp:
Running /home/smarchi/src/binutils-gdb/gdb/testsuite/gdb.base/default.exp ...
FAIL: gdb.base/default.exp: info set
FAIL: gdb.base/default.exp: show
- Make the "debuginfod enabled" setting default to "off" when debuginfod
support is not compiled in, and "ask" otherwise.
- Make the setter of "debuginfod enabled" error out when debuginfod
support is not compiled in, so that "debuginfod enabled" will always
remain "off" in that case.
- Make the setter of "debuginfod verbose" work in any case. I don't
see the harm in letting the user change that setting, since the user will
hit an error if they try to enable the use of debuginfod.
- I would do the same for the "debuginfod urls" setter, but because
this one needs to see the DEBUGINFOD_URLS_ENV_VAR macro, provided by
libdebuginfod, I made that one error out as well if debuginfod
support is not compiled it (otherwise, I would have left it like
"debuginfod verbose". Alternatively, we could hard-code
"DEBUGINFOD_URLS" in the code (in fact, it was prior to this patch,
but I think it was an oversight, as other spots use
DEBUGINFOD_URLS_ENV_VAR), or use a dummy string to store the setting,
but I don't really see the value in that.
Rename debuginfod_enable to debuginfod_enabled, just so it matches the
setting name.
[1] https://sourceware.org/pipermail/gdb-patches/2021-October/182937.html
Change-Id: I45fdb2993f668226a5639228951362b7800f09d5
Co-Authored-By: Aaron Merey <amerey@redhat.com>
2021-11-03 00:21:31 +08:00
|
|
|
add_setshow_enum_cmd ("enabled", class_run, debuginfod_enabled_enum,
|
|
|
|
_("Set whether to use debuginfod."),
|
|
|
|
_("Show whether to use debuginfod."),
|
|
|
|
_("\
|
|
|
|
When on, enable the use of debuginfod to download missing debug info and\n\
|
|
|
|
source files."),
|
|
|
|
set_debuginfod_enabled,
|
|
|
|
get_debuginfod_enabled,
|
|
|
|
show_debuginfod_enabled,
|
|
|
|
&set_debuginfod_prefix_list,
|
|
|
|
&show_debuginfod_prefix_list);
|
2021-10-30 07:55:57 +08:00
|
|
|
|
|
|
|
/* set/show debuginfod urls */
|
|
|
|
add_setshow_string_noescape_cmd ("urls", class_run, _("\
|
|
|
|
Set the list of debuginfod server URLs."), _("\
|
|
|
|
Show the list of debuginfod server URLs."), _("\
|
|
|
|
Manage the space-separated list of debuginfod server URLs that GDB will query \
|
|
|
|
when missing debuginfo, executables or source files.\nThe default value is \
|
|
|
|
copied from the DEBUGINFOD_URLS environment variable."),
|
gdb: rework "set debuginfod" commands
As discussed here [1], do some re-work in the "set debuginfod commands".
First, use "set debuginfod enabled on/off/ask" instead of "set
debuginfod on/off/ask". This is more MI-friendly, and it gives an
output that makes more sense in "info set", for example.
Then, make the show commands not call "error" when debuginfod support is
not compiled in. This makes the commands "show" and "show debuginfod"
stop early, breaking gdb.base/default.exp:
Running /home/smarchi/src/binutils-gdb/gdb/testsuite/gdb.base/default.exp ...
FAIL: gdb.base/default.exp: info set
FAIL: gdb.base/default.exp: show
- Make the "debuginfod enabled" setting default to "off" when debuginfod
support is not compiled in, and "ask" otherwise.
- Make the setter of "debuginfod enabled" error out when debuginfod
support is not compiled in, so that "debuginfod enabled" will always
remain "off" in that case.
- Make the setter of "debuginfod verbose" work in any case. I don't
see the harm in letting the user change that setting, since the user will
hit an error if they try to enable the use of debuginfod.
- I would do the same for the "debuginfod urls" setter, but because
this one needs to see the DEBUGINFOD_URLS_ENV_VAR macro, provided by
libdebuginfod, I made that one error out as well if debuginfod
support is not compiled it (otherwise, I would have left it like
"debuginfod verbose". Alternatively, we could hard-code
"DEBUGINFOD_URLS" in the code (in fact, it was prior to this patch,
but I think it was an oversight, as other spots use
DEBUGINFOD_URLS_ENV_VAR), or use a dummy string to store the setting,
but I don't really see the value in that.
Rename debuginfod_enable to debuginfod_enabled, just so it matches the
setting name.
[1] https://sourceware.org/pipermail/gdb-patches/2021-October/182937.html
Change-Id: I45fdb2993f668226a5639228951362b7800f09d5
Co-Authored-By: Aaron Merey <amerey@redhat.com>
2021-11-03 00:21:31 +08:00
|
|
|
set_debuginfod_urls,
|
|
|
|
get_debuginfod_urls,
|
|
|
|
show_debuginfod_urls,
|
2021-10-30 07:55:57 +08:00
|
|
|
&set_debuginfod_prefix_list,
|
|
|
|
&show_debuginfod_prefix_list);
|
|
|
|
|
|
|
|
/* set/show debuginfod verbose */
|
|
|
|
add_setshow_zuinteger_cmd ("verbose", class_support,
|
|
|
|
&debuginfod_verbose, _("\
|
|
|
|
Set verbosity of debuginfod output."), _("\
|
|
|
|
Show debuginfod debugging."), _("\
|
|
|
|
When set to a non-zero value, display verbose output for each debuginfod \
|
|
|
|
query.\nTo disable, set to zero. Verbose output is displayed by default."),
|
gdb: rework "set debuginfod" commands
As discussed here [1], do some re-work in the "set debuginfod commands".
First, use "set debuginfod enabled on/off/ask" instead of "set
debuginfod on/off/ask". This is more MI-friendly, and it gives an
output that makes more sense in "info set", for example.
Then, make the show commands not call "error" when debuginfod support is
not compiled in. This makes the commands "show" and "show debuginfod"
stop early, breaking gdb.base/default.exp:
Running /home/smarchi/src/binutils-gdb/gdb/testsuite/gdb.base/default.exp ...
FAIL: gdb.base/default.exp: info set
FAIL: gdb.base/default.exp: show
- Make the "debuginfod enabled" setting default to "off" when debuginfod
support is not compiled in, and "ask" otherwise.
- Make the setter of "debuginfod enabled" error out when debuginfod
support is not compiled in, so that "debuginfod enabled" will always
remain "off" in that case.
- Make the setter of "debuginfod verbose" work in any case. I don't
see the harm in letting the user change that setting, since the user will
hit an error if they try to enable the use of debuginfod.
- I would do the same for the "debuginfod urls" setter, but because
this one needs to see the DEBUGINFOD_URLS_ENV_VAR macro, provided by
libdebuginfod, I made that one error out as well if debuginfod
support is not compiled it (otherwise, I would have left it like
"debuginfod verbose". Alternatively, we could hard-code
"DEBUGINFOD_URLS" in the code (in fact, it was prior to this patch,
but I think it was an oversight, as other spots use
DEBUGINFOD_URLS_ENV_VAR), or use a dummy string to store the setting,
but I don't really see the value in that.
Rename debuginfod_enable to debuginfod_enabled, just so it matches the
setting name.
[1] https://sourceware.org/pipermail/gdb-patches/2021-October/182937.html
Change-Id: I45fdb2993f668226a5639228951362b7800f09d5
Co-Authored-By: Aaron Merey <amerey@redhat.com>
2021-11-03 00:21:31 +08:00
|
|
|
nullptr,
|
2021-10-30 07:55:57 +08:00
|
|
|
show_debuginfod_verbose_command,
|
|
|
|
&set_debuginfod_prefix_list,
|
|
|
|
&show_debuginfod_prefix_list);
|
|
|
|
}
|