mirror/autoconf
2
0
Fork 0
mirror of git://git.sv.gnu.org/autoconf synced 2025-02-11 13:51:04 +08:00
Code Issues Packages Projects Releases Wiki Activity

m4sugar: fix AS_VAR_GET regression.

Browse Source 
AS_VAR_GET expands AS_ECHO inside en evaled single quoted string,
which causes the single quotes in "printf '%s\n'" to expose the
%s\n to the shell which expands "\n" to simply "n" before passing
it to printf.
* lib/m4sugar/m4sh.m4 (AS_ECHO): Use double quotes around the
format string.
* doc/autoconf.texi (Limitations of Shell Builtins): Show double
quotes to match AS_ECHO expansion.
* NEWS: Likewise.
This commit is contained in:
Gary V. Vaughan 2013-01-29 19:17:04 +07:00
parent 2b59b6f8a7
commit c3d301efd6
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
NEWS
View File

@ -10,7 +10,7 @@ GNU Autoconf NEWS - User visible changes.
** Use of printf is now recommended instead of working around bugs in ** Use of printf is now recommended instead of working around bugs in
echo. Macros AS_ECHO and AS_ECHO_N now expand unconditionally to echo. Macros AS_ECHO and AS_ECHO_N now expand unconditionally to
"printf '%s\n'" and "printf %s". 'printf "%s\n"' and 'printf %s'.
** Macros ** Macros

2
doc/autoconf.texi
View File

@ -17523,7 +17523,7 @@ only if you know that @var{foo}'s value cannot contain backslashes and
cannot start with @samp{-}. cannot start with @samp{-}.
Normally, @command{printf} is safer and easier to use than @command{echo} Normally, @command{printf} is safer and easier to use than @command{echo}
and @command{echo -n}. Thus, you should use @command{printf '%s\n'} and @command{echo -n}. Thus, you should use @command{printf "%s\n"}
instead of @command{echo}, and similarly use @command{printf %s} instead instead of @command{echo}, and similarly use @command{printf %s} instead
of @command{echo -n}. of @command{echo -n}.

2
lib/m4sugar/m4sh.m4
View File

@ -1026,7 +1026,7 @@ fi
# (typically a quoted string). The bytes of WORD are output as-is, even # (typically a quoted string). The bytes of WORD are output as-is, even
# if it starts with "-" or contains "\". # if it starts with "-" or contains "\".
m4_defun([AS_ECHO], m4_defun([AS_ECHO],
[printf '%s\n' $1]) [printf "%s\n" $1])
# AS_ECHO_N(WORD) # AS_ECHO_N(WORD)