From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 From: James Lyne Date: Mon, 7 Dec 2020 17:52:36 +0000 Subject: [PATCH] Spread out and optimise player list ticksSpread out and optimise player list ticks diff --git a/src/main/java/net/minecraft/server/players/PlayerList.java b/src/main/java/net/minecraft/server/players/PlayerList.java index db23e2afd1b9a7a8e1b29e48a31441b0a64beb5d..dea412353ba3e997d8024cb0770b9ac7300b63a1 100644 --- a/src/main/java/net/minecraft/server/players/PlayerList.java +++ b/src/main/java/net/minecraft/server/players/PlayerList.java @@ -1021,22 +1021,22 @@ public abstract class PlayerList { } public void tick() { - if (++this.sendAllPlayerInfoIn > 600) { - // CraftBukkit start - for (int i = 0; i < this.players.size(); ++i) { - final ServerPlayer target = (ServerPlayer) this.players.get(i); - - target.connection.send(new ClientboundPlayerInfoPacket(ClientboundPlayerInfoPacket.Action.UPDATE_LATENCY, this.players.stream().filter(new Predicate() { - @Override - public boolean apply(ServerPlayer input) { - return target.getBukkitEntity().canSee(input.getBukkitEntity()); - } - }).collect(Collectors.toList()))); + // Purpur start + if (this.sendAllPlayerInfoIn < this.players.size()) { + final org.bukkit.craftbukkit.entity.CraftPlayer target = this.players.get(this.sendAllPlayerInfoIn).getBukkitEntity(); + final List list = new java.util.ArrayList<>(); + for (ServerPlayer player : this.players) { + if (target.canSee(player.getUUID())) { + list.add(player); + } } - // CraftBukkit end - this.sendAllPlayerInfoIn = 0; + target.getHandle().connection.send(new ClientboundPlayerInfoPacket(ClientboundPlayerInfoPacket.Action.UPDATE_LATENCY, list)); } + if (++this.sendAllPlayerInfoIn > 600) { + this.sendAllPlayerInfoIn = 0; + } + // Purpur end } public void broadcastAll(Packet packet) { diff --git a/src/main/java/org/bukkit/craftbukkit/entity/CraftPlayer.java b/src/main/java/org/bukkit/craftbukkit/entity/CraftPlayer.java index b82d150f9b634c5a69cf60e6d1daee9b561cd51b..e8ec6547c11248a2bcc92bbd6226a264f3a51234 100644 --- a/src/main/java/org/bukkit/craftbukkit/entity/CraftPlayer.java +++ b/src/main/java/org/bukkit/craftbukkit/entity/CraftPlayer.java @@ -1741,7 +1741,13 @@ public class CraftPlayer extends CraftHumanEntity implements Player { @Override public boolean canSee(org.bukkit.entity.Entity entity) { - return !this.hiddenEntities.containsKey(entity.getUniqueId()); + // Purpur start + return this.canSee(entity.getUniqueId()); + } + + public boolean canSee(UUID uuid) { + return !this.hiddenEntities.containsKey(uuid); + // Purpur end } @Override