mirror/Plan
2
0
Fork 0
mirror of https://github.com/plan-player-analytics/Plan.git synced 2025-01-18 16:05:43 +08:00
Code Issues Packages Projects Releases Wiki Activity

Patch against bad AFKThreshold setting data

Browse Source 
Patch that resets AFK time of sessions with afk time of length of
the session to 0.

This is a bug remedy patch that attempts to turn "bad" afk data to good.
In 4.5.2 there was a bug that caused some config setting defaults not
being copied, along those AFKThreshold setting,
which lead to AFK threshold being read as 0.
This in turn lead to full sessions being regarded as having been AFK.
This commit is contained in:
Rsl1122 2019-01-17 11:00:20 +02:00
parent d6ef6ec566
commit baca629857
2 changed files with 73 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Plan/common/src/main/java/com/djrapitops/plan/system/database/databases/sql/SQLDB.java
View File

@ -200,7 +200,8 @@ public abstract class SQLDB extends Database {
new GeoInfoOptimizationPatch(this),
new TransferTableRemovalPatch(this),
new IPHashPatch(this),
new IPAnonPatch(this)
new IPAnonPatch(this),
new BadAFKThresholdValuePatch(this)
};
}

71
Plan/common/src/main/java/com/djrapitops/plan/system/database/databases/sql/patches/BadAFKThresholdValuePatch.java Normal file
View File

@ -0,0 +1,71 @@
/*
* This file is part of Player Analytics (Plan).
*
* Plan is free software: you can redistribute it and/or modify
* it under the terms of the GNU Lesser General Public License v3 as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* Plan is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public License
* along with Plan. If not, see <https://www.gnu.org/licenses/>.
*/
package com.djrapitops.plan.system.database.databases.sql.patches;
import com.djrapitops.plan.system.database.databases.sql.SQLDB;
import com.djrapitops.plan.system.database.databases.sql.processing.QueryAllStatement;
import com.djrapitops.plan.system.database.databases.sql.tables.SessionsTable;
import java.sql.ResultSet;
import java.sql.SQLException;
/**
* Patch that resets AFK time of sessions with afk time of length of the session to 0.
* <p>
* This is a bug remedy patch that attempts to turn "bad" afk data to good.
* In 4.5.2 there was a bug that caused some config setting defaults not being copied, along those
* AFKThreshold setting, which lead to AFK threshold being read as 0.
* This in turn lead to full sessions being regarded as having been AFK.
*
* @author Rsl1122
*/
public class BadAFKThresholdValuePatch extends Patch {
public BadAFKThresholdValuePatch(SQLDB db) {
super(db);
}
@Override
public boolean hasBeenApplied() {
return !containsSessionsWithFullAFK();
}
private boolean containsSessionsWithFullAFK() {
// where |afk - session_length| < 5
String sql = "SELECT COUNT(1) as found FROM " + SessionsTable.TABLE_NAME +
" WHERE ABS(" +
SessionsTable.Col.AFK_TIME +
" - (" + SessionsTable.Col.SESSION_END + "-" + SessionsTable.Col.SESSION_START +
")) < 5 AND " + SessionsTable.Col.AFK_TIME + "!=0";
return query(new QueryAllStatement<Boolean>(sql) {
@Override
public Boolean processResults(ResultSet set) throws SQLException {
return set.next() && set.getInt("found") > 0;
}
});
}
@Override
protected void applyPatch() {
// where |afk - session_length| < 5
String sql = "UPDATE " + SessionsTable.TABLE_NAME + " SET " + SessionsTable.Col.AFK_TIME + "=0 WHERE ABS(" +
SessionsTable.Col.AFK_TIME +
" - (" + SessionsTable.Col.SESSION_END + "-" + SessionsTable.Col.SESSION_START +
")) < 5 AND " + SessionsTable.Col.AFK_TIME + "!=0";
db.execute(sql);
}
}