2014-02-01 04:42:29 +08:00
|
|
|
From 9aa2c9cab36f62efe112ad012cd715aeedfb4609 Mon Sep 17 00:00:00 2001
|
2013-02-27 01:21:40 +08:00
|
|
|
From: Aikar <aikar@aikar.co>
|
|
|
|
Date: Thu, 10 Jan 2013 00:18:11 -0500
|
|
|
|
Subject: [PATCH] Improved Timings System
|
|
|
|
|
|
|
|
Tracks nearly every point of minecraft internals and plugin events to give a good quick overview on what is causing TPS loss.
|
|
|
|
|
|
|
|
diff --git a/src/main/java/net/minecraft/server/ChunkProviderServer.java b/src/main/java/net/minecraft/server/ChunkProviderServer.java
|
2013-12-18 14:48:18 +08:00
|
|
|
index 9c99177..b88f75c 100644
|
2013-02-27 01:21:40 +08:00
|
|
|
--- a/src/main/java/net/minecraft/server/ChunkProviderServer.java
|
|
|
|
+++ b/src/main/java/net/minecraft/server/ChunkProviderServer.java
|
2013-12-18 14:48:18 +08:00
|
|
|
@@ -106,6 +106,7 @@ public class ChunkProviderServer implements IChunkProvider {
|
2013-02-27 01:21:40 +08:00
|
|
|
// CraftBukkit end
|
|
|
|
|
|
|
|
if (chunk == null) {
|
|
|
|
+ org.bukkit.craftbukkit.SpigotTimings.syncChunkLoadTimer.startTiming(); // Spigot
|
|
|
|
chunk = this.loadChunk(i, j);
|
|
|
|
if (chunk == null) {
|
|
|
|
if (this.chunkProvider == null) {
|
2013-12-18 14:48:18 +08:00
|
|
|
@@ -141,6 +142,7 @@ public class ChunkProviderServer implements IChunkProvider {
|
2013-12-01 11:40:53 +08:00
|
|
|
}
|
2013-02-27 01:21:40 +08:00
|
|
|
// CraftBukkit end
|
|
|
|
chunk.a(this, this, i, j);
|
|
|
|
+ org.bukkit.craftbukkit.SpigotTimings.syncChunkLoadTimer.stopTiming(); // Spigot
|
|
|
|
}
|
|
|
|
|
|
|
|
// CraftBukkit start - If we didn't need to load the chunk run the callback now
|
|
|
|
diff --git a/src/main/java/net/minecraft/server/Entity.java b/src/main/java/net/minecraft/server/Entity.java
|
2014-02-01 04:42:29 +08:00
|
|
|
index f74d937..ff07aa7 100644
|
2013-02-27 01:21:40 +08:00
|
|
|
--- a/src/main/java/net/minecraft/server/Entity.java
|
|
|
|
+++ b/src/main/java/net/minecraft/server/Entity.java
|
2013-03-16 05:35:56 +08:00
|
|
|
@@ -14,6 +14,7 @@ import org.bukkit.block.BlockFace;
|
2013-02-27 01:21:40 +08:00
|
|
|
import org.bukkit.entity.LivingEntity;
|
|
|
|
import org.bukkit.entity.Painting;
|
|
|
|
import org.bukkit.entity.Vehicle;
|
2013-06-02 09:29:44 +08:00
|
|
|
+import org.spigotmc.CustomTimingsHandler; // Spigot
|
2013-02-27 01:21:40 +08:00
|
|
|
import org.bukkit.event.entity.EntityCombustByEntityEvent;
|
|
|
|
import org.bukkit.event.painting.PaintingBreakByEntityEvent;
|
|
|
|
import org.bukkit.event.vehicle.VehicleBlockCollisionEvent;
|
2014-02-01 04:42:29 +08:00
|
|
|
@@ -111,6 +112,8 @@ public abstract class Entity {
|
2013-07-02 11:03:56 +08:00
|
|
|
public boolean valid; // CraftBukkit
|
2014-02-01 04:42:29 +08:00
|
|
|
public org.bukkit.projectiles.ProjectileSource projectileSource; // CraftBukkit - For projectiles only
|
2013-02-27 01:21:40 +08:00
|
|
|
|
|
|
|
+ public CustomTimingsHandler tickTimer = org.bukkit.craftbukkit.SpigotTimings.getEntityTimings(this); // Spigot
|
|
|
|
+
|
2013-12-01 11:40:53 +08:00
|
|
|
public int getId() {
|
|
|
|
return this.id;
|
|
|
|
}
|
2014-02-01 04:42:29 +08:00
|
|
|
@@ -424,6 +427,8 @@ public abstract class Entity {
|
2013-12-01 11:40:53 +08:00
|
|
|
return;
|
2013-04-13 15:06:23 +08:00
|
|
|
}
|
|
|
|
// CraftBukkit end
|
2013-12-01 11:40:53 +08:00
|
|
|
+
|
2013-02-27 01:21:40 +08:00
|
|
|
+ org.bukkit.craftbukkit.SpigotTimings.entityMoveTimer.startTiming(); // Spigot
|
2013-12-01 11:40:53 +08:00
|
|
|
if (this.Y) {
|
2013-02-27 01:21:40 +08:00
|
|
|
this.boundingBox.d(d0, d1, d2);
|
|
|
|
this.locX = (this.boundingBox.a + this.boundingBox.d) / 2.0D;
|
2014-02-01 04:42:29 +08:00
|
|
|
@@ -732,6 +737,7 @@ public abstract class Entity {
|
2013-02-27 01:21:40 +08:00
|
|
|
|
|
|
|
this.world.methodProfiler.b();
|
|
|
|
}
|
|
|
|
+ org.bukkit.craftbukkit.SpigotTimings.entityMoveTimer.stopTiming(); // Spigot
|
|
|
|
}
|
|
|
|
|
2013-12-01 11:40:53 +08:00
|
|
|
protected String H() {
|
2013-02-27 01:21:40 +08:00
|
|
|
diff --git a/src/main/java/net/minecraft/server/MinecraftServer.java b/src/main/java/net/minecraft/server/MinecraftServer.java
|
2014-01-22 16:23:59 +08:00
|
|
|
index 6a01982..2519af6 100644
|
2013-02-27 01:21:40 +08:00
|
|
|
--- a/src/main/java/net/minecraft/server/MinecraftServer.java
|
|
|
|
+++ b/src/main/java/net/minecraft/server/MinecraftServer.java
|
2013-12-01 11:40:53 +08:00
|
|
|
@@ -10,7 +10,6 @@ import java.util.ArrayList;
|
|
|
|
import java.util.Arrays;
|
|
|
|
import java.util.Collections;
|
2013-02-27 01:21:40 +08:00
|
|
|
import java.util.Date;
|
|
|
|
-import java.util.Iterator;
|
|
|
|
import java.util.List;
|
2013-12-01 11:40:53 +08:00
|
|
|
import java.util.Random;
|
|
|
|
import java.util.UUID;
|
|
|
|
@@ -36,6 +35,7 @@ import jline.console.ConsoleReader;
|
2013-02-27 01:21:40 +08:00
|
|
|
import joptsimple.OptionSet;
|
|
|
|
|
|
|
|
import org.bukkit.World.Environment;
|
|
|
|
+import org.bukkit.craftbukkit.SpigotTimings; // Spigot
|
|
|
|
import org.bukkit.craftbukkit.util.Waitable;
|
|
|
|
import org.bukkit.event.server.RemoteServerCommandEvent;
|
|
|
|
import org.bukkit.event.world.WorldSaveEvent;
|
2014-01-22 16:23:59 +08:00
|
|
|
@@ -531,6 +531,7 @@ public abstract class MinecraftServer implements ICommandListener, Runnable, IMo
|
|
|
|
protected void s() {}
|
|
|
|
|
|
|
|
protected void t() throws ExceptionWorldConflict { // CraftBukkit - added throws
|
|
|
|
+ SpigotTimings.serverTickTimer.startTiming(); // Spigot
|
|
|
|
long i = System.nanoTime();
|
|
|
|
|
|
|
|
AxisAlignedBB.a().a();
|
|
|
|
@@ -583,6 +584,7 @@ public abstract class MinecraftServer implements ICommandListener, Runnable, IMo
|
2013-12-01 11:40:53 +08:00
|
|
|
public void u() {
|
2013-02-27 01:21:40 +08:00
|
|
|
this.methodProfiler.a("levels");
|
|
|
|
|
|
|
|
+ SpigotTimings.schedulerTimer.startTiming(); // Spigot
|
2013-03-25 15:57:00 +08:00
|
|
|
// CraftBukkit start
|
2013-02-27 01:21:40 +08:00
|
|
|
this.server.getScheduler().mainThreadHeartbeat(this.ticks);
|
|
|
|
|
2014-01-22 16:23:59 +08:00
|
|
|
@@ -591,7 +593,10 @@ public abstract class MinecraftServer implements ICommandListener, Runnable, IMo
|
2013-02-27 01:21:40 +08:00
|
|
|
processQueue.remove().run();
|
|
|
|
}
|
|
|
|
|
|
|
|
+ SpigotTimings.schedulerTimer.stopTiming(); // Spigot
|
|
|
|
+ SpigotTimings.chunkIOTickTimer.startTiming(); // Spigot
|
|
|
|
org.bukkit.craftbukkit.chunkio.ChunkIOExecutor.tick();
|
|
|
|
+ SpigotTimings.chunkIOTickTimer.stopTiming(); // Spigot
|
|
|
|
|
2013-03-25 15:57:00 +08:00
|
|
|
// Send time updates to everyone, it will get the right time from the world the player is in.
|
2013-02-27 01:21:40 +08:00
|
|
|
if (this.ticks % 20 == 0) {
|
2014-01-22 16:23:59 +08:00
|
|
|
@@ -643,7 +648,9 @@ public abstract class MinecraftServer implements ICommandListener, Runnable, IMo
|
2013-02-27 01:21:40 +08:00
|
|
|
|
|
|
|
this.methodProfiler.b();
|
|
|
|
this.methodProfiler.a("tracker");
|
|
|
|
+ worldserver.timings.tracker.startTiming(); // Spigot
|
|
|
|
worldserver.getTracker().updatePlayers();
|
|
|
|
+ worldserver.timings.tracker.stopTiming(); // Spigot
|
|
|
|
this.methodProfiler.b();
|
|
|
|
this.methodProfiler.b();
|
|
|
|
// } // CraftBukkit
|
2014-01-22 16:23:59 +08:00
|
|
|
@@ -652,16 +659,24 @@ public abstract class MinecraftServer implements ICommandListener, Runnable, IMo
|
2013-02-27 01:21:40 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
this.methodProfiler.c("connection");
|
|
|
|
+ SpigotTimings.connectionTimer.startTiming(); // Spigot
|
2013-12-01 11:40:53 +08:00
|
|
|
this.ag().c();
|
2013-02-27 01:21:40 +08:00
|
|
|
+ SpigotTimings.connectionTimer.stopTiming(); // Spigot
|
|
|
|
this.methodProfiler.c("players");
|
|
|
|
+ SpigotTimings.playerListTimer.startTiming(); // Spigot
|
2013-07-02 11:03:56 +08:00
|
|
|
this.t.tick();
|
2013-02-27 01:21:40 +08:00
|
|
|
+ SpigotTimings.playerListTimer.stopTiming(); // Spigot
|
|
|
|
this.methodProfiler.c("tickables");
|
|
|
|
|
|
|
|
+ SpigotTimings.tickablesTimer.startTiming(); // Spigot
|
2013-12-01 11:40:53 +08:00
|
|
|
for (i = 0; i < this.m.size(); ++i) {
|
|
|
|
((IUpdatePlayerListBox) this.m.get(i)).a();
|
2013-02-27 01:21:40 +08:00
|
|
|
}
|
|
|
|
+ SpigotTimings.tickablesTimer.stopTiming(); // Spigot
|
|
|
|
|
|
|
|
this.methodProfiler.b();
|
2014-01-22 16:23:59 +08:00
|
|
|
+ SpigotTimings.serverTickTimer.stopTiming(); // Spigot
|
|
|
|
+ org.spigotmc.CustomTimingsHandler.tick(); // Spigot
|
2013-02-27 01:21:40 +08:00
|
|
|
}
|
2014-01-22 16:23:59 +08:00
|
|
|
|
|
|
|
public boolean getAllowNether() {
|
2013-02-27 01:21:40 +08:00
|
|
|
diff --git a/src/main/java/net/minecraft/server/PlayerConnection.java b/src/main/java/net/minecraft/server/PlayerConnection.java
|
2014-02-01 04:42:29 +08:00
|
|
|
index ee6b0a1..d9e64a3 100644
|
2013-02-27 01:21:40 +08:00
|
|
|
--- a/src/main/java/net/minecraft/server/PlayerConnection.java
|
|
|
|
+++ b/src/main/java/net/minecraft/server/PlayerConnection.java
|
2013-12-21 16:13:39 +08:00
|
|
|
@@ -917,6 +917,7 @@ public class PlayerConnection implements PacketPlayInListener {
|
2013-02-27 01:21:40 +08:00
|
|
|
// CraftBukkit end
|
|
|
|
|
|
|
|
private void handleCommand(String s) {
|
|
|
|
+ org.bukkit.craftbukkit.SpigotTimings.playerCommandTimer.startTiming(); // Spigot
|
|
|
|
// CraftBukkit start
|
|
|
|
CraftPlayer player = this.getPlayer();
|
|
|
|
|
2013-12-21 16:13:39 +08:00
|
|
|
@@ -924,19 +925,23 @@ public class PlayerConnection implements PacketPlayInListener {
|
2013-02-27 01:21:40 +08:00
|
|
|
this.server.getPluginManager().callEvent(event);
|
|
|
|
|
|
|
|
if (event.isCancelled()) {
|
|
|
|
+ org.bukkit.craftbukkit.SpigotTimings.playerCommandTimer.stopTiming(); // Spigot
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
try {
|
2013-12-01 11:40:53 +08:00
|
|
|
this.c.info(event.getPlayer().getName() + " issued server command: " + event.getMessage()); // CraftBukkit
|
2013-02-27 01:21:40 +08:00
|
|
|
if (this.server.dispatchCommand(event.getPlayer(), event.getMessage().substring(1))) {
|
|
|
|
+ org.bukkit.craftbukkit.SpigotTimings.playerCommandTimer.stopTiming(); // Spigot
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
} catch (org.bukkit.command.CommandException ex) {
|
|
|
|
player.sendMessage(org.bukkit.ChatColor.RED + "An internal error occurred while attempting to perform this command");
|
2013-03-25 15:57:00 +08:00
|
|
|
java.util.logging.Logger.getLogger(PlayerConnection.class.getName()).log(java.util.logging.Level.SEVERE, null, ex);
|
2013-02-27 01:21:40 +08:00
|
|
|
+ org.bukkit.craftbukkit.SpigotTimings.playerCommandTimer.stopTiming(); // Spigot
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
+ org.bukkit.craftbukkit.SpigotTimings.playerCommandTimer.stopTiming(); // Spigot
|
2013-12-01 11:40:53 +08:00
|
|
|
//this.minecraftServer.getCommandHandler().a(this.player, s);
|
2013-02-27 01:21:40 +08:00
|
|
|
// CraftBukkit end
|
2013-12-01 11:40:53 +08:00
|
|
|
}
|
2013-02-27 01:21:40 +08:00
|
|
|
diff --git a/src/main/java/net/minecraft/server/TileEntity.java b/src/main/java/net/minecraft/server/TileEntity.java
|
2013-12-01 11:40:53 +08:00
|
|
|
index 811f1a4..3de32fe 100644
|
2013-02-27 01:21:40 +08:00
|
|
|
--- a/src/main/java/net/minecraft/server/TileEntity.java
|
|
|
|
+++ b/src/main/java/net/minecraft/server/TileEntity.java
|
2013-12-01 11:40:53 +08:00
|
|
|
@@ -7,10 +7,12 @@ import java.util.concurrent.Callable;
|
|
|
|
import org.apache.logging.log4j.LogManager;
|
|
|
|
import org.apache.logging.log4j.Logger;
|
2013-02-27 01:21:40 +08:00
|
|
|
|
2013-06-02 09:29:44 +08:00
|
|
|
+import org.spigotmc.CustomTimingsHandler; // Spigot
|
2013-02-27 01:21:40 +08:00
|
|
|
import org.bukkit.inventory.InventoryHolder; // CraftBukkit
|
|
|
|
|
|
|
|
public class TileEntity {
|
|
|
|
|
|
|
|
+ public CustomTimingsHandler tickTimer = org.bukkit.craftbukkit.SpigotTimings.getTileEntityTimings(this); // Spigot
|
2013-12-01 11:40:53 +08:00
|
|
|
private static final Logger a = LogManager.getLogger();
|
|
|
|
private static Map i = new HashMap();
|
|
|
|
private static Map j = new HashMap();
|
2013-02-27 01:21:40 +08:00
|
|
|
diff --git a/src/main/java/net/minecraft/server/World.java b/src/main/java/net/minecraft/server/World.java
|
2013-12-22 07:05:27 +08:00
|
|
|
index 00c2a18..f1bf467 100644
|
2013-02-27 01:21:40 +08:00
|
|
|
--- a/src/main/java/net/minecraft/server/World.java
|
|
|
|
+++ b/src/main/java/net/minecraft/server/World.java
|
2013-12-03 12:13:39 +08:00
|
|
|
@@ -14,6 +14,7 @@ import java.util.concurrent.Callable;
|
2013-02-27 01:21:40 +08:00
|
|
|
import org.bukkit.Bukkit;
|
2013-12-03 12:13:39 +08:00
|
|
|
import org.bukkit.craftbukkit.util.CraftMagicNumbers;
|
2013-02-27 01:21:40 +08:00
|
|
|
import org.bukkit.craftbukkit.util.LongHashSet;
|
|
|
|
+import org.bukkit.craftbukkit.SpigotTimings; // Spigot
|
|
|
|
import org.bukkit.craftbukkit.util.UnsafeList;
|
|
|
|
import org.bukkit.generator.ChunkGenerator;
|
|
|
|
import org.bukkit.craftbukkit.CraftServer;
|
2013-12-09 15:00:58 +08:00
|
|
|
@@ -133,6 +134,8 @@ public abstract class World implements IBlockAccess {
|
2013-02-27 01:21:40 +08:00
|
|
|
final Object chunkLock = new Object();
|
2013-06-20 16:52:23 +08:00
|
|
|
public final org.spigotmc.SpigotWorldConfig spigotConfig; // Spigot
|
2013-02-27 01:21:40 +08:00
|
|
|
|
|
|
|
+ public final SpigotTimings.WorldTimingsHandler timings; // Spigot
|
|
|
|
+
|
|
|
|
public CraftWorld getWorld() {
|
|
|
|
return this.world;
|
|
|
|
}
|
2013-12-09 15:00:58 +08:00
|
|
|
@@ -212,6 +215,7 @@ public abstract class World implements IBlockAccess {
|
2013-02-27 01:21:40 +08:00
|
|
|
this.a();
|
|
|
|
|
|
|
|
this.getServer().addWorld(this.world); // CraftBukkit
|
|
|
|
+ timings = new SpigotTimings.WorldTimingsHandler(this); // Spigot
|
|
|
|
}
|
|
|
|
|
|
|
|
protected abstract IChunkProvider j();
|
2013-12-22 07:05:27 +08:00
|
|
|
@@ -1230,6 +1234,7 @@ public abstract class World implements IBlockAccess {
|
2013-02-27 01:21:40 +08:00
|
|
|
this.f.clear();
|
|
|
|
this.methodProfiler.c("regular");
|
|
|
|
|
|
|
|
+ timings.entityTick.startTiming(); // Spigot
|
|
|
|
for (i = 0; i < this.entityList.size(); ++i) {
|
|
|
|
entity = (Entity) this.entityList.get(i);
|
|
|
|
|
2013-12-22 07:05:27 +08:00
|
|
|
@@ -1252,7 +1257,9 @@ public abstract class World implements IBlockAccess {
|
2013-02-27 01:21:40 +08:00
|
|
|
this.methodProfiler.a("tick");
|
|
|
|
if (!entity.dead) {
|
|
|
|
try {
|
|
|
|
+ SpigotTimings.tickEntityTimer.startTiming(); // Spigot
|
|
|
|
this.playerJoinedWorld(entity);
|
|
|
|
+ SpigotTimings.tickEntityTimer.stopTiming(); // Spigot
|
|
|
|
} catch (Throwable throwable1) {
|
|
|
|
crashreport = CrashReport.a(throwable1, "Ticking entity");
|
|
|
|
crashreportsystemdetails = crashreport.a("Entity being ticked");
|
2013-12-22 07:05:27 +08:00
|
|
|
@@ -1277,7 +1284,9 @@ public abstract class World implements IBlockAccess {
|
2013-02-27 01:21:40 +08:00
|
|
|
this.methodProfiler.b();
|
|
|
|
}
|
|
|
|
|
|
|
|
+ timings.entityTick.stopTiming(); // Spigot
|
2013-12-01 11:40:53 +08:00
|
|
|
this.methodProfiler.c("blockEntities");
|
2013-02-27 01:21:40 +08:00
|
|
|
+ timings.tileEntityTick.startTiming(); // Spigot
|
2013-03-16 05:35:56 +08:00
|
|
|
this.N = true;
|
2013-02-27 01:21:40 +08:00
|
|
|
Iterator iterator = this.tileEntityList.iterator();
|
|
|
|
|
2013-12-22 07:05:27 +08:00
|
|
|
@@ -1292,8 +1301,11 @@ public abstract class World implements IBlockAccess {
|
2013-02-27 01:21:40 +08:00
|
|
|
|
|
|
|
if (!tileentity.r() && tileentity.o() && this.isLoaded(tileentity.x, tileentity.y, tileentity.z)) {
|
|
|
|
try {
|
|
|
|
+ tileentity.tickTimer.startTiming(); // Spigot
|
2013-03-16 05:35:56 +08:00
|
|
|
tileentity.h();
|
2013-02-27 01:21:40 +08:00
|
|
|
+ tileentity.tickTimer.stopTiming(); // Spigot
|
|
|
|
} catch (Throwable throwable2) {
|
|
|
|
+ tileentity.tickTimer.stopTiming(); // Spigot
|
2013-12-01 11:40:53 +08:00
|
|
|
crashreport = CrashReport.a(throwable2, "Ticking block entity");
|
|
|
|
crashreportsystemdetails = crashreport.a("Block entity being ticked");
|
2013-03-16 05:35:56 +08:00
|
|
|
tileentity.a(crashreportsystemdetails);
|
2013-12-22 07:05:27 +08:00
|
|
|
@@ -1313,6 +1325,8 @@ public abstract class World implements IBlockAccess {
|
2013-02-27 01:21:40 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
+ timings.tileEntityTick.stopTiming(); // Spigot
|
|
|
|
+ timings.tileEntityPending.startTiming(); // Spigot
|
2013-03-16 05:35:56 +08:00
|
|
|
this.N = false;
|
2013-02-27 01:21:40 +08:00
|
|
|
if (!this.b.isEmpty()) {
|
|
|
|
this.tileEntityList.removeAll(this.b);
|
2013-12-22 07:05:27 +08:00
|
|
|
@@ -1351,6 +1365,7 @@ public abstract class World implements IBlockAccess {
|
2013-02-27 01:21:40 +08:00
|
|
|
this.a.clear();
|
|
|
|
}
|
|
|
|
|
|
|
|
+ timings.tileEntityPending.stopTiming(); // Spigot
|
|
|
|
this.methodProfiler.b();
|
|
|
|
this.methodProfiler.b();
|
|
|
|
}
|
2013-12-22 07:05:27 +08:00
|
|
|
@@ -1373,6 +1388,7 @@ public abstract class World implements IBlockAccess {
|
2013-02-27 01:21:40 +08:00
|
|
|
byte b0 = 32;
|
|
|
|
|
2013-12-01 11:40:53 +08:00
|
|
|
if (!flag || this.b(i - b0, 0, j - b0, i + b0, 0, j + b0)) {
|
2013-02-27 01:21:40 +08:00
|
|
|
+ entity.tickTimer.startTiming(); // Spigot
|
2013-12-01 11:40:53 +08:00
|
|
|
entity.T = entity.locX;
|
|
|
|
entity.U = entity.locY;
|
|
|
|
entity.V = entity.locZ;
|
2013-12-22 07:05:27 +08:00
|
|
|
@@ -1434,6 +1450,7 @@ public abstract class World implements IBlockAccess {
|
2013-02-27 01:21:40 +08:00
|
|
|
entity.passenger = null;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
+ entity.tickTimer.stopTiming(); // Spigot
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
diff --git a/src/main/java/net/minecraft/server/WorldServer.java b/src/main/java/net/minecraft/server/WorldServer.java
|
2014-01-22 16:16:12 +08:00
|
|
|
index a0e4ade..9672508 100644
|
2013-02-27 01:21:40 +08:00
|
|
|
--- a/src/main/java/net/minecraft/server/WorldServer.java
|
|
|
|
+++ b/src/main/java/net/minecraft/server/WorldServer.java
|
2013-12-01 11:40:53 +08:00
|
|
|
@@ -184,10 +184,12 @@ public class WorldServer extends World implements org.bukkit.BlockChangeDelegate
|
2013-02-27 01:21:40 +08:00
|
|
|
// CraftBukkit start - Only call spawner if we have players online and the world allows for mobs or animals
|
|
|
|
long time = this.worldData.getTime();
|
|
|
|
if (this.getGameRules().getBoolean("doMobSpawning") && (this.allowMonsters || this.allowAnimals) && (this instanceof WorldServer && this.players.size() > 0)) {
|
|
|
|
+ timings.mobSpawn.startTiming(); // Spigot
|
2013-12-01 11:40:53 +08:00
|
|
|
this.R.spawnEntities(this, this.allowMonsters && (this.ticksPerMonsterSpawns != 0 && time % this.ticksPerMonsterSpawns == 0L), this.allowAnimals && (this.ticksPerAnimalSpawns != 0 && time % this.ticksPerAnimalSpawns == 0L), this.worldData.getTime() % 400L == 0L);
|
|
|
|
- // CraftBukkit end
|
2013-02-27 01:21:40 +08:00
|
|
|
+ timings.mobSpawn.stopTiming(); // Spigot
|
|
|
|
}
|
2013-12-01 11:40:53 +08:00
|
|
|
-
|
|
|
|
+ // CraftBukkit end
|
2013-06-08 07:21:38 +08:00
|
|
|
+ timings.doChunkUnload.startTiming(); // Spigot
|
2013-02-27 01:21:40 +08:00
|
|
|
this.methodProfiler.c("chunkSource");
|
|
|
|
this.chunkProvider.unloadChunks();
|
|
|
|
int j = this.a(1.0F);
|
2013-12-01 11:40:53 +08:00
|
|
|
@@ -201,21 +203,36 @@ public class WorldServer extends World implements org.bukkit.BlockChangeDelegate
|
2013-07-02 11:03:56 +08:00
|
|
|
this.worldData.setDayTime(this.worldData.getDayTime() + 1L);
|
|
|
|
}
|
2013-06-08 07:21:38 +08:00
|
|
|
|
|
|
|
+ timings.doChunkUnload.stopTiming(); // Spigot
|
|
|
|
this.methodProfiler.c("tickPending");
|
|
|
|
+ timings.doTickPending.startTiming(); // Spigot
|
|
|
|
this.a(false);
|
|
|
|
+ timings.doTickPending.stopTiming(); // Spigot
|
2013-12-01 11:40:53 +08:00
|
|
|
this.methodProfiler.c("tickBlocks");
|
2013-06-08 07:21:38 +08:00
|
|
|
+ timings.doTickTiles.startTiming(); // Spigot
|
|
|
|
this.g();
|
|
|
|
+ timings.doTickTiles.stopTiming(); // Spigot
|
|
|
|
this.methodProfiler.c("chunkMap");
|
|
|
|
+ timings.doChunkMap.startTiming(); // Spigot
|
|
|
|
this.manager.flush();
|
|
|
|
+ timings.doChunkMap.stopTiming(); // Spigot
|
|
|
|
this.methodProfiler.c("village");
|
|
|
|
+ timings.doVillages.startTiming(); // Spigot
|
|
|
|
this.villages.tick();
|
|
|
|
this.siegeManager.a();
|
|
|
|
+ timings.doVillages.stopTiming(); // Spigot
|
|
|
|
this.methodProfiler.c("portalForcer");
|
|
|
|
+ timings.doPortalForcer.startTiming(); // Spigot
|
2013-12-01 11:40:53 +08:00
|
|
|
this.Q.a(this.getTime());
|
2013-06-08 07:21:38 +08:00
|
|
|
+ timings.doPortalForcer.stopTiming(); // Spigot
|
|
|
|
this.methodProfiler.b();
|
|
|
|
+ timings.doSounds.startTiming(); // Spigot
|
2013-12-01 11:40:53 +08:00
|
|
|
this.Z();
|
2013-06-08 07:21:38 +08:00
|
|
|
+ timings.doSounds.stopTiming(); // Spigot
|
2013-07-02 11:03:56 +08:00
|
|
|
|
2013-06-08 07:21:38 +08:00
|
|
|
+ timings.doChunkGC.startTiming(); // Spigot
|
2013-02-27 01:21:40 +08:00
|
|
|
this.getWorld().processChunkGC(); // CraftBukkit
|
2013-06-08 07:21:38 +08:00
|
|
|
+ timings.doChunkGC.stopTiming(); // Spigot
|
2013-02-27 01:21:40 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
public BiomeMeta a(EnumCreatureType enumcreaturetype, int i, int j, int k) {
|
|
|
|
diff --git a/src/main/java/org/bukkit/craftbukkit/SpigotTimings.java b/src/main/java/org/bukkit/craftbukkit/SpigotTimings.java
|
|
|
|
new file mode 100644
|
2013-08-03 17:39:35 +08:00
|
|
|
index 0000000..8340c13
|
2013-02-27 01:21:40 +08:00
|
|
|
--- /dev/null
|
|
|
|
+++ b/src/main/java/org/bukkit/craftbukkit/SpigotTimings.java
|
2013-08-03 17:39:35 +08:00
|
|
|
@@ -0,0 +1,125 @@
|
2013-02-27 01:21:40 +08:00
|
|
|
+package org.bukkit.craftbukkit;
|
|
|
|
+
|
|
|
|
+import net.minecraft.server.*;
|
2013-06-02 09:29:44 +08:00
|
|
|
+import org.spigotmc.CustomTimingsHandler;
|
2013-02-27 01:21:40 +08:00
|
|
|
+import org.bukkit.scheduler.BukkitTask;
|
|
|
|
+
|
|
|
|
+import java.util.HashMap;
|
2013-08-03 17:39:35 +08:00
|
|
|
+import org.bukkit.craftbukkit.scheduler.CraftTask;
|
2013-02-27 01:21:40 +08:00
|
|
|
+
|
|
|
|
+public class SpigotTimings {
|
|
|
|
+
|
|
|
|
+ public static final CustomTimingsHandler serverTickTimer = new CustomTimingsHandler("** Full Server Tick");
|
|
|
|
+ public static final CustomTimingsHandler playerListTimer = new CustomTimingsHandler("Player List");
|
2013-03-02 07:40:13 +08:00
|
|
|
+ public static final CustomTimingsHandler connectionTimer = new CustomTimingsHandler("Player Tick");
|
2013-02-27 01:21:40 +08:00
|
|
|
+ public static final CustomTimingsHandler tickablesTimer = new CustomTimingsHandler("Tickables");
|
|
|
|
+ public static final CustomTimingsHandler schedulerTimer = new CustomTimingsHandler("Scheduler");
|
|
|
|
+ public static final CustomTimingsHandler chunkIOTickTimer = new CustomTimingsHandler("ChunkIOTick");
|
|
|
|
+ public static final CustomTimingsHandler syncChunkLoadTimer = new CustomTimingsHandler("syncChunkLoad");
|
|
|
|
+
|
|
|
|
+ public static final CustomTimingsHandler entityMoveTimer = new CustomTimingsHandler("** entityMove");
|
|
|
|
+ public static final CustomTimingsHandler tickEntityTimer = new CustomTimingsHandler("** tickEntity");
|
|
|
|
+ public static final CustomTimingsHandler activatedEntityTimer = new CustomTimingsHandler("** activatedTickEntity");
|
|
|
|
+ public static final CustomTimingsHandler tickTileEntityTimer = new CustomTimingsHandler("** tickTileEntity");
|
|
|
|
+
|
|
|
|
+ public static final CustomTimingsHandler timerEntityBaseTick = new CustomTimingsHandler("** livingEntityBaseTick");
|
|
|
|
+ public static final CustomTimingsHandler timerEntityAI = new CustomTimingsHandler("** livingEntityAI");
|
|
|
|
+ public static final CustomTimingsHandler timerEntityAICollision = new CustomTimingsHandler("** livingEntityAICollision");
|
|
|
|
+ public static final CustomTimingsHandler timerEntityAIMove = new CustomTimingsHandler("** livingEntityAIMove");
|
|
|
|
+ public static final CustomTimingsHandler timerEntityTickRest = new CustomTimingsHandler("** livingEntityTickRest");
|
|
|
|
+
|
|
|
|
+ public static final CustomTimingsHandler playerCommandTimer = new CustomTimingsHandler("** playerCommand");
|
|
|
|
+
|
|
|
|
+ public static final HashMap<String, CustomTimingsHandler> entityTypeTimingMap = new HashMap<String, CustomTimingsHandler>();
|
|
|
|
+ public static final HashMap<String, CustomTimingsHandler> tileEntityTypeTimingMap = new HashMap<String, CustomTimingsHandler>();
|
|
|
|
+ public static final HashMap<String, CustomTimingsHandler> pluginTaskTimingMap = new HashMap<String, CustomTimingsHandler>();
|
|
|
|
+
|
|
|
|
+ /**
|
|
|
|
+ * Gets a timer associated with a plugins tasks.
|
|
|
|
+ * @param task
|
|
|
|
+ * @param period
|
|
|
|
+ * @return
|
|
|
|
+ */
|
|
|
|
+ public static CustomTimingsHandler getPluginTaskTimings(BukkitTask task, long period) {
|
|
|
|
+ String plugin = task.getOwner().getDescription().getFullName();
|
2013-08-03 17:39:35 +08:00
|
|
|
+ String name = "Task: " + plugin + " Runnable: " + ( (CraftTask) task ).getTaskClass().getSimpleName();
|
2013-02-27 01:21:40 +08:00
|
|
|
+ if (period > 0) {
|
2013-02-27 13:39:53 +08:00
|
|
|
+ name += "(interval:" + period +")";
|
2013-02-27 01:21:40 +08:00
|
|
|
+ } else {
|
2013-02-27 13:39:53 +08:00
|
|
|
+ name += "(Single)";
|
2013-02-27 01:21:40 +08:00
|
|
|
+ }
|
2013-02-27 13:39:53 +08:00
|
|
|
+ CustomTimingsHandler result = pluginTaskTimingMap.get(name);
|
|
|
|
+ if (result == null) {
|
|
|
|
+ result = new CustomTimingsHandler(name);
|
|
|
|
+ pluginTaskTimingMap.put(name, result);
|
|
|
|
+ }
|
|
|
|
+ return result;
|
2013-02-27 01:21:40 +08:00
|
|
|
+ }
|
|
|
|
+
|
|
|
|
+ /**
|
|
|
|
+ * Get a named timer for the specified entity type to track type specific timings.
|
|
|
|
+ * @param entity
|
|
|
|
+ * @return
|
|
|
|
+ */
|
|
|
|
+ public static CustomTimingsHandler getEntityTimings(Entity entity) {
|
|
|
|
+ String entityType = entity.getClass().getSimpleName();
|
|
|
|
+ CustomTimingsHandler result = entityTypeTimingMap.get(entityType);
|
|
|
|
+ if (result == null) {
|
|
|
|
+ result = new CustomTimingsHandler("** tickEntity - " + entityType, activatedEntityTimer);
|
|
|
|
+ entityTypeTimingMap.put(entityType, result);
|
|
|
|
+ }
|
|
|
|
+ return result;
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
+ /**
|
|
|
|
+ * Get a named timer for the specified tile entity type to track type specific timings.
|
|
|
|
+ * @param entity
|
|
|
|
+ * @return
|
|
|
|
+ */
|
|
|
|
+ public static CustomTimingsHandler getTileEntityTimings(TileEntity entity) {
|
|
|
|
+ String entityType = entity.getClass().getSimpleName();
|
|
|
|
+ CustomTimingsHandler result = tileEntityTypeTimingMap.get(entityType);
|
|
|
|
+ if (result == null) {
|
|
|
|
+ result = new CustomTimingsHandler("** tickTileEntity - " + entityType, tickTileEntityTimer);
|
|
|
|
+ tileEntityTypeTimingMap.put(entityType, result);
|
|
|
|
+ }
|
|
|
|
+ return result;
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
+ /**
|
|
|
|
+ * Set of timers per world, to track world specific timings.
|
|
|
|
+ */
|
|
|
|
+ public static class WorldTimingsHandler {
|
|
|
|
+ public final CustomTimingsHandler mobSpawn;
|
2013-06-08 07:21:38 +08:00
|
|
|
+ public final CustomTimingsHandler doChunkUnload;
|
|
|
|
+ public final CustomTimingsHandler doPortalForcer;
|
|
|
|
+ public final CustomTimingsHandler doTickPending;
|
|
|
|
+ public final CustomTimingsHandler doTickTiles;
|
|
|
|
+ public final CustomTimingsHandler doVillages;
|
|
|
|
+ public final CustomTimingsHandler doChunkMap;
|
|
|
|
+ public final CustomTimingsHandler doChunkGC;
|
|
|
|
+ public final CustomTimingsHandler doSounds;
|
2013-02-27 01:21:40 +08:00
|
|
|
+ public final CustomTimingsHandler entityTick;
|
|
|
|
+ public final CustomTimingsHandler tileEntityTick;
|
|
|
|
+ public final CustomTimingsHandler tileEntityPending;
|
|
|
|
+ public final CustomTimingsHandler tracker;
|
|
|
|
+
|
|
|
|
+ public WorldTimingsHandler(World server) {
|
|
|
|
+ String name = server.worldData.getName() +" - ";
|
|
|
|
+
|
|
|
|
+ mobSpawn = new CustomTimingsHandler(name + "mobSpawn");
|
2013-06-08 07:21:38 +08:00
|
|
|
+ doChunkUnload = new CustomTimingsHandler(name + "doChunkUnload");
|
|
|
|
+ doTickPending = new CustomTimingsHandler(name + "doTickPending");
|
|
|
|
+ doTickTiles = new CustomTimingsHandler(name + "doTickTiles");
|
|
|
|
+ doVillages = new CustomTimingsHandler(name + "doVillages");
|
|
|
|
+ doChunkMap = new CustomTimingsHandler(name + "doChunkMap");
|
|
|
|
+ doSounds = new CustomTimingsHandler(name + "doSounds");
|
|
|
|
+ doChunkGC = new CustomTimingsHandler(name + "doChunkGC");
|
|
|
|
+ doPortalForcer = new CustomTimingsHandler(name + "doPortalForcer");
|
2013-02-27 01:21:40 +08:00
|
|
|
+ entityTick = new CustomTimingsHandler(name + "entityTick");
|
|
|
|
+ tileEntityTick = new CustomTimingsHandler(name + "tileEntityTick");
|
|
|
|
+ tileEntityPending = new CustomTimingsHandler(name + "tileEntityPending");
|
|
|
|
+ tracker = new CustomTimingsHandler(name + "tracker");
|
|
|
|
+ }
|
|
|
|
+ }
|
|
|
|
+}
|
|
|
|
diff --git a/src/main/java/org/bukkit/craftbukkit/scheduler/CraftTask.java b/src/main/java/org/bukkit/craftbukkit/scheduler/CraftTask.java
|
2013-08-03 17:39:35 +08:00
|
|
|
index 55db3ff..7d294c0 100644
|
2013-02-27 01:21:40 +08:00
|
|
|
--- a/src/main/java/org/bukkit/craftbukkit/scheduler/CraftTask.java
|
|
|
|
+++ b/src/main/java/org/bukkit/craftbukkit/scheduler/CraftTask.java
|
2013-08-03 17:39:35 +08:00
|
|
|
@@ -1,11 +1,13 @@
|
2013-02-27 01:21:40 +08:00
|
|
|
package org.bukkit.craftbukkit.scheduler;
|
|
|
|
|
|
|
|
import org.bukkit.Bukkit;
|
|
|
|
+import org.bukkit.craftbukkit.SpigotTimings; // Spigot
|
2013-06-02 09:29:44 +08:00
|
|
|
+import org.spigotmc.CustomTimingsHandler; // Spigot
|
2013-02-27 01:21:40 +08:00
|
|
|
import org.bukkit.plugin.Plugin;
|
|
|
|
import org.bukkit.scheduler.BukkitTask;
|
|
|
|
|
2013-08-03 17:39:35 +08:00
|
|
|
|
|
|
|
-class CraftTask implements BukkitTask, Runnable {
|
|
|
|
+public class CraftTask implements BukkitTask, Runnable { // Spigot
|
|
|
|
|
|
|
|
private volatile CraftTask next = null;
|
|
|
|
/**
|
2013-02-27 01:21:40 +08:00
|
|
|
@@ -22,6 +24,7 @@ class CraftTask implements BukkitTask, Runnable {
|
|
|
|
private final Plugin plugin;
|
|
|
|
private final int id;
|
|
|
|
|
|
|
|
+ CustomTimingsHandler timings = null; // Spigot
|
|
|
|
CraftTask() {
|
|
|
|
this(null, null, -1, -1);
|
|
|
|
}
|
|
|
|
@@ -50,7 +53,22 @@ class CraftTask implements BukkitTask, Runnable {
|
|
|
|
}
|
|
|
|
|
|
|
|
public void run() {
|
|
|
|
+ // Spigot start - Wrap custom timings on Tasks
|
|
|
|
+ if (!Bukkit.getServer().getPluginManager().useTimings()) {
|
|
|
|
+ task.run();
|
|
|
|
+ return;
|
|
|
|
+ }
|
|
|
|
+ if (timings == null && this.getOwner() != null && this.isSync()) {
|
|
|
|
+ timings = SpigotTimings.getPluginTaskTimings(this, period);
|
|
|
|
+ }
|
|
|
|
+ if (timings != null) {
|
|
|
|
+ timings.startTiming();
|
|
|
|
+ }
|
|
|
|
task.run();
|
|
|
|
+ if (timings != null) {
|
|
|
|
+ timings.stopTiming();
|
|
|
|
+ }
|
|
|
|
+ // Spigot end
|
|
|
|
}
|
|
|
|
|
|
|
|
long getPeriod() {
|
2013-08-03 17:39:35 +08:00
|
|
|
@@ -77,7 +95,7 @@ class CraftTask implements BukkitTask, Runnable {
|
|
|
|
this.next = next;
|
|
|
|
}
|
|
|
|
|
|
|
|
- Class<? extends Runnable> getTaskClass() {
|
|
|
|
+ public Class<? extends Runnable> getTaskClass() { // Spigot
|
|
|
|
return task.getClass();
|
|
|
|
}
|
|
|
|
|
2013-02-27 01:21:40 +08:00
|
|
|
--
|
2014-02-01 04:42:29 +08:00
|
|
|
1.8.4.msysgit.0
|
2013-02-27 01:21:40 +08:00
|
|
|
|