From c61c0b46c9afb2f294fb7523ec987b2d87ec791e Mon Sep 17 00:00:00 2001
From: Bjarne Koll <LynxPlay101@gmail.com>
Date: Fri, 22 Jul 2022 10:03:09 +0200
Subject: [PATCH] Prevent Steps#next on final version creation step (#773)

---
 frontend/src/pages/[user]/[project]/versions/new.vue | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/frontend/src/pages/[user]/[project]/versions/new.vue b/frontend/src/pages/[user]/[project]/versions/new.vue
index 285397761..4426eae2a 100644
--- a/frontend/src/pages/[user]/[project]/versions/new.vue
+++ b/frontend/src/pages/[user]/[project]/versions/new.vue
@@ -62,7 +62,8 @@ const steps: Step[] = [
     value: "changelog",
     header: t("version.new.steps.4.header"),
     beforeNext: async () => {
-      return createVersion();
+      await createVersion();
+      return false; // createVersion already hijacks the beforeNext logic, cannot move next on final step.
     },
   },
 ];
@@ -147,7 +148,7 @@ async function createPendingVersion() {
 
 async function createVersion() {
   if (!pendingVersion.value) {
-    return false;
+    return;
   }
 
   loading.submit = true;
@@ -177,10 +178,8 @@ async function createVersion() {
   try {
     await useInternalApi(`versions/version/${props.project.id}/create`, true, "post", pendingVersion.value);
     await router.push(`/${route.params.user}/${route.params.project}/versions`);
-    return true;
   } catch (e: any) {
     handleRequestError(e, ctx, i18n);
-    return false;
   } finally {
     loading.submit = false;
   }