mirror/Hangar
2
0
Fork 0
mirror of https://github.com/HangarMC/Hangar.git synced 2024-12-03 06:22:35 +08:00
Code Issues Packages Projects Releases Wiki Activity

Prevent Steps#next on final version creation step (#773)

Browse Source
This commit is contained in:
Bjarne Koll 2022-07-22 10:03:09 +02:00 committed by GitHub
parent 51e436d18c
commit c61c0b46c9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
frontend/src/pages/[user]/[project]/versions/new.vue
View File

@ -62,7 +62,8 @@ const steps: Step[] = [
value: "changelog",
header: t("version.new.steps.4.header"),
beforeNext: async () => {
return createVersion();
await createVersion();
return false; // createVersion already hijacks the beforeNext logic, cannot move next on final step.
},
},
];
@ -147,7 +148,7 @@ async function createPendingVersion() {
async function createVersion() {
if (!pendingVersion.value) {
return false;
return;
}
loading.submit = true;
@ -177,10 +178,8 @@ async function createVersion() {
try {
await useInternalApi(`versions/version/${props.project.id}/create`, true, "post", pendingVersion.value);
await router.push(`/${route.params.user}/${route.params.project}/versions`);
return true;
} catch (e: any) {
handleRequestError(e, ctx, i18n);
return false;
} finally {
loading.submit = false;
}